-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention the point of BlendMode.plus and advise on using it. #44189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 31, 2023
…131638) flutter/engine@b83172a...fe23695 2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from faca95f7e81b to 196713767078 (7 revisions) (flutter/engine#44191) 2023-07-31 ian@hixie.ch Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187) 2023-07-31 chinmaygarde@google.com [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186) 2023-07-31 chinmaygarde@google.com [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182) 2023-07-31 jason-simmons@users.noreply.github.com [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179) 2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from 2755f73a3461 to faca95f7e81b (1 revision) (flutter/engine#44178) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131638) flutter/engine@b83172a...fe23695 2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from faca95f7e81b to 196713767078 (7 revisions) (flutter/engine#44191) 2023-07-31 ian@hixie.ch Mention the point of BlendMode.plus and advise on using it. (flutter/engine#44189) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from db813f4043fe to 2e5f08012a92 (1 revision) (flutter/engine#44187) 2023-07-31 chinmaygarde@google.com [Impeller] Update guidance on how to try Impeller on macOS Desktop. (flutter/engine#44186) 2023-07-31 chinmaygarde@google.com [Impeller] Add a descriptive blurb about newer Impeller components and fix links. (flutter/engine#44183) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 06174bc8f4d5 to db813f4043fe (1 revision) (flutter/engine#44182) 2023-07-31 jason-simmons@users.noreply.github.com [Impeller] Create a wrapper Impeller context for each Vulkan surface and its swapchain (flutter/engine#44171) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from ea0c9c0935ae to 06174bc8f4d5 (2 revisions) (flutter/engine#44179) 2023-07-31 skia-flutter-autoroll@skia.org Roll ANGLE from 2755f73a3461 to faca95f7e81b (1 revision) (flutter/engine#44178) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 9c12eb0e158a to ea0c9c0935ae (4 revisions) (flutter/engine#44177) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from 685e29df6704 to 9c12eb0e158a (2 revisions) (flutter/engine#44173) 2023-07-31 skia-flutter-autoroll@skia.org Roll Skia from cb61dd4af8a5 to 685e29df6704 (2 revisions) (flutter/engine#44170) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.