-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove physical geometry #47825
Remove physical geometry #47825
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like this was proactively added in flutter/engine#20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery. Related engine PR: flutter/engine#47825
824596d
to
dda9066
Compare
auto label is removed for flutter/engine/47825, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dda9066
to
ea84bc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web bits LGTM! /cc @mdebbar fyi!
auto label is removed for flutter/engine/47825, due to Pull request flutter/engine/47825 is not in a mergeable state. |
This reverts commit ff13610.
Reverts #47825 Initiated by: zanderso This change reverts the following previous change: Original Description: Looks like this was proactively added in #20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery. Related framework PR: flutter/flutter#138103 (Checks will fail until that PR is submitted).
…sions) (#138154) Manual roll requested by zra@google.com flutter/engine@8b490a9...35cad36 2023-11-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove physical geometry" (flutter/engine#47862) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 7d0768083298 to df263765ebc8 (2 revisions) (flutter/engine#47860) 2023-11-09 chillers@google.com Reland "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47823) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from 8f8c9a144797 to 7d0768083298 (1 revision) (flutter/engine#47858) 2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 6f36eb00cacf to 6bd98dc2dffd (1 revision) (flutter/engine#47857) 2023-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 14933042494d to 6f36eb00cacf (4 revisions) (flutter/engine#47855) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b055626ce8c2 to 8f8c9a144797 (1 revision) (flutter/engine#47854) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from b6ce84dc3e53 to b055626ce8c2 (1 revision) (flutter/engine#47850) 2023-11-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sD8HRA4JmXczujkqO... to 0pD5ceqf-e9y9NTNn... (flutter/engine#47847) 2023-11-09 goderbauer@google.com Remove physical geometry (flutter/engine#47825) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from f3e4fd80eeeb to b6ce84dc3e53 (1 revision) (flutter/engine#47843) 2023-11-09 skia-flutter-autoroll@skia.org Roll Skia from d9ec01cf15ff to f3e4fd80eeeb (3 revisions) (flutter/engine#47838) 2023-11-09 737941+loic-sharma@users.noreply.github.com [Windows] Remove global state in keyboard tests (flutter/engine#47829) 2023-11-08 mdebbar@google.com [web] Non-singleton implementation of ui.FlutterView (flutter/engine#47806) 2023-11-08 gspencergoog@users.noreply.github.com Move window state update to window realize callback (flutter/engine#47713) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from sD8HRA4JmXcz to 0pD5ceqf-e9y If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Thanks for the ping @ditman! Yeah, this probably had conflicts with my PR but looks like @goderbauer took care of it :) |
Relands #47825 with a doc fix (see second commit).
Looks like this was proactively added in #20496, but never wired up to anything on any platform. It is also unused in framework and customer code; we never exposed this on e.g. MediaQuery.
Related framework PR: flutter/flutter#138103 (Checks will fail until that PR is submitted).