[Impeller] dont accidentally copy shared ptr. #49731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
NTE: Semantic change that isn't observable outside of benchmarks. |
matanlurey
approved these changes
Jan 11, 2024
|
test-exempt: cleanups. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 12, 2024
…141432) flutter/engine@ecdaed7...44a0a6e 2024-01-12 skia-flutter-autoroll@skia.org Roll Skia from d65d18ac1e8d to e9de42588e54 (1 revision) (flutter/engine#49738) 2024-01-11 matanlurey@users.noreply.github.com Add `SurfaceTextureSurfaceProducer` (flutter/engine#49653) 2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from b63e5a3c14e1 to d65d18ac1e8d (1 revision) (flutter/engine#49735) 2024-01-11 jonahwilliams@google.com [Impeller] Begin migrating to RenderPass command recording API. (flutter/engine#49480) 2024-01-11 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 only (flutter/engine#49722) 2024-01-11 jonahwilliams@google.com [Impeller] dont accidentally copy shared ptr. (flutter/engine#49731) 2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 56f28f137507 to b63e5a3c14e1 (1 revision) (flutter/engine#49733) 2024-01-11 jason-simmons@users.noreply.github.com Revert Dart SDK to 3245b92a5930 (flutter/engine#49727) 2024-01-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gJuGKaWsKazIrvQeO... to Klxww53tA4-TG5pA9... (flutter/engine#49730) 2024-01-11 103135467+sealesj@users.noreply.github.com Google GitHub mirrors - reland (flutter/engine#49716) 2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 440f5f849008 to 56f28f137507 (1 revision) (flutter/engine#49723) 2024-01-11 103135467+sealesj@users.noreply.github.com Osv-scanner integration (flutter/engine#49470) 2024-01-11 jason-simmons@users.noreply.github.com [Impeller] Add DrawLine/DrawOval/ClipOval operations to the canvas recorder (flutter/engine#49697) 2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 7f3ea1c3bc27 to 6f5bd26b293d (1 revision) (flutter/engine#49720) 2024-01-11 dnfield@google.com Try to get GLES tests running... (flutter/engine#49701) 2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from 2a5710618fc3 to 440f5f849008 (1 revision) (flutter/engine#49715) 2024-01-11 skia-flutter-autoroll@skia.org Roll Skia from c46008e5a839 to 2a5710618fc3 (1 revision) (flutter/engine#49712) 2024-01-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 3245b92a5930 to 7f3ea1c3bc27 (1 revision) (flutter/engine#49710) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gJuGKaWsKazI to Klxww53tA4-T If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the shared ptr when we don't need to results in us incrementing/decrementing the ref count which isn't free.