[Impeller] Allow playgrounds to use SwiftShader via a flag. #50298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying the `--use_swiftshader` flag will find an setup the SwiftShader ICD in the process. Allows switching between two Vulkan implementation (system and SwiftShader) quickly using a flag. Following up on flutter/flutter#127070
gaaclarke
approved these changes
Feb 2, 2024
| //------------------------------------------------------------------------------ | ||
| /// @brief Find and setup the installable client driver for a locally built | ||
| /// SwiftShader at known paths. The option to use SwiftShader can | ||
| /// only be used one in the process. While calling this method |
There was a problem hiding this comment.
Suggested change
| /// only be used one in the process. While calling this method | |
| /// only be used once in the process. While calling this method |
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Feb 2, 2024
…default on macOS. Similar to --use_swiftshader in flutter#50298.
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Feb 2, 2024
…default on macOS. Similar to --use_swiftshader in flutter#50298.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 3, 2024
…142842) flutter/engine@78c63d3...9869d47 2024-02-02 chinmaygarde@google.com [Impeller] Allow playgrounds to use SwiftShader via a flag. (flutter/engine#50298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the
--use_swiftshaderflag will find an setup the SwiftShader ICD in the process. Allows switching between two Vulkan implementation (system and SwiftShader) quickly using a flag.Following up on flutter/flutter#127070