Adjust Android emulator test timeouts #51004
Conversation
.ci.yaml
Outdated
| @@ -55,6 +55,7 @@ targets: | |||
| recipe: engine_v2/engine_v2 | |||
| properties: | |||
| config_name: linux_android_emulator | |||
| test_timeout_secs: "5400" # 90 minutes | |||
There was a problem hiding this comment.
The test will timeout after at most 60 mins, as the subbuild's execution timeout is 60 mins. And the subbuild's timeout number is consistent with orchestrator's. Where do you see the 90 mins?
There was a problem hiding this comment.
On line 63, timeout: 90.
There was a problem hiding this comment.
If this doesn't change the subbuilds execution time, then what does? I don't see any other way to do it.
There was a problem hiding this comment.
My bad using an outdate local config repo (which missed the recent change: #50954)
Subbuild's execution_timeout is not controllable from .ci.yaml side as of now. All subbuilds of different targets are sharing the same Drone builder. We can change it to 90, but it will affect all drone builds. This should work for other targets (whose orchestrator is with 60), the subbuild will be killed anyway after 60 mins, but it may cause confusion where subbuild's timeout is bigger than the orchestrator's.
As in this PR, we are reducing test step timeout from 30 to 15mins, and the retry from 3 to 2, do we still need the 90 timeout for subbuild?
There was a problem hiding this comment.
Is there an issue filed for allowing controlling subbuild execution timeout? That seems like a pretty basic feature, and the existing ci properties lead one to believe that it is controllable.
There was a problem hiding this comment.
I removed the test_timeout_secs field.
There was a problem hiding this comment.
flutter/flutter#144243 to track.
e5a0971
to
3655261
Compare
2461280c38 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (flutter/engine#51011) 8940ea0887 Code consistency fixes in FlScrollingManager (flutter/engine#50959) 21474ee4a4 [macOS] Use CVDisplayLink to drive repaint (flutter/engine#49159) 6f7b939568 Fail lazily when 1+ Skia gold comparions fail. (flutter/engine#51010) 249daf5512 Adjust Android emulator test timeouts (flutter/engine#51004)
This reduces the scenario app test timeout from 30 minutes to 15 minutes (passing runs seem to take about 5 minutes), and limits the scenario app tests from 2 retries to only 1 retry.
These changes will hopefully allow logs collection to be successful when the tests timeout.