Use RBE for mac_clang_tidy #51083
Merged
Use RBE for mac_clang_tidy #51083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
commented
Feb 29, 2024
| @@ -67,6 +76,23 @@ | |||
| "osx_sdk" | |||
| ], | |||
| "tasks": [ | |||
| { | |||
| "name": "gn for host_debug", | |||
There was a problem hiding this comment.
This is a bit crufty, but ensures that the symlinks referred to by the compile_commands.json are created as expected.
There was a problem hiding this comment.
Does this mean for Mac builds, we need to run gn config twice to make it right? One before the ninja build, and the other here after ninja?
There was a problem hiding this comment.
This is only needed because the test is a global test and we disabled the code to copy the prebuilts folder and symlinks to/from cas. If the test is running as part of a build, then the extra gn isn't needed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
…144416) flutter/engine@1f24eaa...bb6c6a0 2024-02-29 jonahwilliams@google.com [Impeller] test removal of submit batching. (flutter/engine#51094) 2024-02-29 zanderso@users.noreply.github.com Use RBE for mac_clang_tidy (flutter/engine#51083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.