[go: nahoru, domu]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter Loading
base: ddf60fb08733
Choose a base ref
...
head repository: flutter/flutter Loading
compare: 5dea6b994e8f
Choose a head ref
  • 5 commits
  • 11 files changed
  • 4 contributors

Commits on Jan 20, 2024

  1. Roll Flutter Engine from 704ef3399012 to 2b31ad2fb819 (1 revision) (#…

    …141937)
    
    flutter/engine@704ef33...2b31ad2
    
    2024-01-20 skia-flutter-autoroll@skia.org Roll Skia from 3cac1efbdd7a to c42ac527ff0e (1 revision) (flutter/engine#49921)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    954d30f View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. Add RadioListItem use-case to a11y_assessments (#140984)

    Adds a use-case screen for `RadioListTile`, similar to the `CheckBoxListTile`. This screen can help test scenarios such as the one reported in #126805.
    yjbanov committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    a9faaf2 View commit details
    Browse the repository at this point in the history
  2. Adjust the position of require File.expand_path (#141521)

    On `Podfile`:
    
    ```ruby
    flutter_application_path = '../flutter_module'
    load File.join(flutter_application_path, '.ios', 'Flutter', 'podhelper.rb')
    
    target 'OCProject' do
      # Comment the next line if you don't want to use dynamic frameworks
      use_frameworks!
    
      # Pods for OCProject
      # install_all_flutter_pods(flutter_application_path)
      # install_flutter_engine_pod(flutter_application_path)
      # install_flutter_application_pod(flutter_application_path)
      install_flutter_plugin_pods(flutter_application_path)
    
    end
    
    post_install do |installer|
      flutter_post_install(installer)
    end
    ```
    Encountering the following error after executing `pod install`:
    
    ```shell
    pod install
    
    [!] Invalid `Podfile` file: undefined method `flutter_relative_path_from_podfile' for #<Pod::Podfile:0x000000010e74c520 @defined_in_file=#<Pathname:/Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile>, @internal_hash={}, @root_target_definitions=[#<Pod::Podfile::TargetDefinition label=Pods>], @current_target_definition=#<Pod::Podfile::TargetDefinition label=Pods>>
    
      relative = flutter_relative_path_from_podfile(export_script_directory)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^.
    
     #  from /Users/lxf/gitHub/flutter_hybrid_bug/OCProject/Podfile:17
     #  -------------------------------------------
     #    # install_flutter_plugin_pods(flutter_application_path)
     >    install_flutter_application_pod(flutter_application_path)
     #
     #  -------------------------------------------
    ```
    
    The `flutter_relative_path_from_podfile` method is in `flutter_tools/bin/podhelper.rb`, but now `flutter_tools/bin/podhelper.rb` is only required in `install_all_flutter_pods` in `podhelper.rb.tmpl`.
    
    Sometimes we only need to use the `install_flutter_plugin_pods` method in podhelper.rb. For example, using `Shorebird` in an iOS hybird app scenario, we need to build `Flutter.xcframework` and `App.xcframework` and embed them into the iOS native project. In order to avoid unnecessary conflicts, use `install_flutter_plugin_pods` method to install Flutter plugin pods.
    
    [Shorebird - Code Push In Hybrid Apps](https://docs.shorebird.dev/guides/hybrid-app/ios)
    
    So I adjust the position of `require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root)`.
    LinXunFeng committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    f340d20 View commit details
    Browse the repository at this point in the history
  3. [flutter_tools] update analyze_once_test.dart to be null-safe (#141790)

    Fixes #141743
    
    I should have made this change in #124039, but it escaped my grep search.
    christopherfujino committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    9209480 View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 2b31ad2fb819 to a7b207d5a1fe (1 revision) (#…

    …141945)
    
    flutter/engine@2b31ad2...a7b207d
    
    2024-01-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kOnlSGX_aTAK7vvLc... to p0njgljtokVLYfzqK... (flutter/engine#49924)
    
    Also rolling transitive DEPS:
      fuchsia/sdk/core/linux-amd64 from kOnlSGX_aTAK to p0njgljtokVL
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    5dea6b9 View commit details
    Browse the repository at this point in the history
Loading