[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages/flutter_tools/test/integration.shard/analyze_once_test.dart to stop using language 2.7 #141743

Closed
scheglov opened this issue Jan 18, 2024 · 3 comments · Fixed by #141790
Closed

Update packages/flutter_tools/test/integration.shard/analyze_once_test.dart to stop using language 2.7 #141743

scheglov opened this issue Jan 18, 2024 · 3 comments · Fixed by #141790
Assignees
@christopherfujino
Labels
team-tool Owned by Flutter Tool team

Comments

@scheglov
Copy link
Contributor

This causes issues with developing Dart analyzer.
See #141576
@scheglov scheglov mentioned this issue Jan 18, 2024
Closed
@zanderso zanderso added the team-tool Owned by Flutter Tool team label Jan 18, 2024
@zanderso
Copy link
Member

cc @christopherfujino

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 18, 2024
@scheglov
Revert two CLs that remove WithoutNullSafetyMixin usages.
1719ef3 
There is code in Flutter that verifies the analyzer with language
verison `2.7`, and breaks if we remove legacy support.

I opened flutter/flutter#141743

Bug: flutter/flutter#141576
Change-Id: I9ec47c2126149ead49cdead82f49fd9eb80a75ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346948
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
@christopherfujino christopherfujino self-assigned this Jan 18, 2024
@christopherfujino
Copy link
Member

Good catch

@christopherfujino christopherfujino mentioned this issue Jan 18, 2024
Merged
auto-submit bot pushed a commit that referenced this issue Jan 21, 2024
@christopherfujino
[flutter_tools] update analyze_once_test.dart to be null-safe (#141790)
9209480 
Fixes #141743

I should have made this change in #124039, but it escaped my grep search.
@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 4, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherfujino christopherfujino

Labels
team-tool Owned by Flutter Tool team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[flutter_tools] update analyze_once_test.dart to be null-safe christopherfujino/flutter
3 participants
@scheglov @zanderso @christopherfujino