[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin_tools] Restrict update-excerpts change detection to READMEs #111592

Closed
stuartmorgan opened this issue Sep 14, 2022 · 1 comment · Fixed by flutter/plugins#6950
Closed

[plugin_tools] Restrict update-excerpts change detection to READMEs #111592

stuartmorgan opened this issue Sep 14, 2022 · 1 comment · Fixed by flutter/plugins#6950
Labels
p: tooling Affects the flutter_plugin_tools package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@stuartmorgan
Copy link
Contributor

The code here fails if any files have changed. In some cases completely unrelated files could be dirty (e.g., flutter pub get can adjust some files), and we shouldn't fail in that case. We should filter the list of changed files to only README.md files.

(This is especially bad in conjunction with #111590.)
@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin p: tooling Affects the flutter_plugin_tools package P1 High-priority issues at the top of the work list labels Sep 14, 2022
This was referenced Jan 12, 2023
Merged
Merged
stuartmorgan added a commit to flutter/plugins that referenced this issue Jan 13, 2023
@stuartmorgan
[tool] Fix false positives in update-exceprts (#6950)
92a5367 
When determining whether or not to fail with `--fail-on-change`, only
look at .md files. In some cases, running the necessary commands (e.g.,
`flutter pub get`) may change unrelated files, causing fales positive
failures. Only changed documentation files should be flagged.

Also log the specific files that were detected as changed, to aid in
debugging any future false positives.

Fixes flutter/flutter#111592
Fixes flutter/flutter#111590
mauricioluz pushed a commit to mauricioluz/plugins that referenced this issue Jan 26, 2023
@stuartmorgan @mauricioluz
[tool] Fix false positives in update-exceprts (flutter#6950)
18c38b3 
When determining whether or not to fail with `--fail-on-change`, only
look at .md files. In some cases, running the necessary commands (e.g.,
`flutter pub get`) may change unrelated files, causing fales positive
failures. Only changed documentation files should be flagged.

Also log the specific files that were detected as changed, to aid in
debugging any future false positives.

Fixes flutter/flutter#111592
Fixes flutter/flutter#111590
stuartmorgan added a commit to flutter/packages that referenced this issue Feb 13, 2023
@stuartmorgan
[tool] Fix false positives in update-exceprts (#6950)
459e806 
When determining whether or not to fail with `--fail-on-change`, only
look at .md files. In some cases, running the necessary commands (e.g.,
`flutter pub get`) may change unrelated files, causing fales positive
failures. Only changed documentation files should be flagged.

Also log the specific files that were detected as changed, to aid in
debugging any future false positives.

Fixes flutter/flutter#111592
Fixes flutter/flutter#111590
@github-actions
Copy link
github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p: tooling Affects the flutter_plugin_tools package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tool] Fix false positives in update-exceprts stuartmorgan/plugins
1 participant
@stuartmorgan