[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to finders.dart to use a namespace in controller.dart #136421

Closed
pdblasi-google opened this issue Oct 11, 2023 · 1 comment · Fixed by #136423
Closed

Update references to finders.dart to use a namespace in controller.dart #136421

pdblasi-google opened this issue Oct 11, 2023 · 1 comment · Fixed by #136423
Assignees
@pdblasi-google
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@pdblasi-google
Copy link
Contributor

The SemanticsController.find method in controller.dart ends up shadowing finders.dart#find when trying to use finders.dart#find in SemanticsController. This led to a possible workaround that we'd like to avoid in #132598, so this ticket is to track properly updating the import to avoid the shadowing altogether. This is being done in a separate issue to prevent overcrowding the #132598 PR.
@pdblasi-google pdblasi-google added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Oct 11, 2023
@pdblasi-google pdblasi-google self-assigned this Oct 11, 2023
@pdblasi-google pdblasi-google mentioned this issue Oct 11, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this issue Oct 12, 2023
@pdblasi-google
Updates references to finders.dart in controller.dart to use a na…
fa827eb 
…mespace. (#136423)

Updates references to `finders.dart` in `controller.dart` to use a namespace. This enables us to make use of `finders.dart#find` in `SemanticsController` without anything being shadowed.

Fixes #136421
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pdblasi-google pdblasi-google

Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates references to finders.dart in controller.dart to use a namespace. pdblasi-google/flutter
1 participant
@pdblasi-google