[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform_views_scroll_perf__timeline_summary:99th_percentile_frame_build_time_millis 250% regression #144255

Closed
gaaclarke opened this issue Feb 27, 2024 · 3 comments
Closed

platform_views_scroll_perf__timeline_summary:99th_percentile_frame_build_time_millis 250% regression #144255

gaaclarke opened this issue Feb 27, 2024 · 3 comments
Labels
c: regression It was better in the past than it is now team-engine Owned by Engine team

Comments

@gaaclarke
Copy link
Member

introduction #144208

skia-perf
@gaaclarke gaaclarke added c: regression It was better in the past than it is now team-engine Owned by Engine team labels Feb 27, 2024
@gaaclarke
Copy link
Member Author

This is probably a result of flutter/engine#50976

@jonahwilliams jonahwilliams mentioned this issue Feb 27, 2024
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Feb 28, 2024
@jonahwilliams
[Impeller] Cache entire render target and not just allocations. (#50990)
5574bf5 
This may be required to fix flutter/flutter#144116 , and in general the safety of the render pass caches.

Because the RenderPass / Framebuffer objects refer to specific attachments, the caches are placed on the resolve texture, which is "real". The stencil/depth and or MSAA textures may be different but that didn't seem to matter on many Android devices. It doesn't seem like its actually valid though, whether or not there is a validation error to catch it.

I can confirm this fixes flutter/flutter#144116  locally.

This change moves the cache one level up to cover the properties of the RenderTarget we care about, and ensures that we always use the same attachment combinations.

Fixes flutter/flutter#141750
Maybe flutter/flutter#144255 ?
@jonahwilliams
Copy link
Member

We looked into this more and the cause was the multiview PR that landed and was reverted changed how the work was scheduled in a way that reduce the measured workload of the framework.

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: regression It was better in the past than it is now team-engine Owned by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonahwilliams @gaaclarke