[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter first-party plugins CI tests should run on master and stable for every change #42377

Closed
collinjackson opened this issue Oct 10, 2019 · 3 comments · Fixed by flutter/plugins#2197 or flutter/plugins#2203
Closed

Flutter first-party plugins CI tests should run on master and stable for every change #42377

collinjackson opened this issue Oct 10, 2019 · 3 comments · Fixed by flutter/plugins#2197 or flutter/plugins#2203
Assignees
@collinjackson
Labels
package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@collinjackson
Copy link
Contributor

This will ensure that the first-party plugins work on both branches.

We probably only need to run the analyzer on master though.
@collinjackson collinjackson added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin labels Oct 10, 2019
@mklim
Copy link
Contributor
mklim commented Oct 10, 2019

This is particularly important because we guarantee that our 1.0.0 plugins support stable, but right now we're only testing them on CI with master and we generally develop with master. We've had multiple bugs in the past where we've accidentally regressed stable in ways that CI would have caught.

@collinjackson collinjackson mentioned this issue Oct 15, 2019
Merged
@collinjackson collinjackson self-assigned this Oct 15, 2019
@mklim mklim mentioned this issue Oct 16, 2019
Merged
13 tasks
@mklim
Copy link
Contributor
mklim commented Oct 16, 2019

This was reopened by flutter/plugins@c155379.

@mklim mklim reopened this Oct 16, 2019
@collinjackson collinjackson mentioned this issue Oct 16, 2019
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@collinjackson collinjackson

Labels
package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
2 participants
@collinjackson @mklim