This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Enable testing on both master and stable #2197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mklim
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be good if we also tracked average CI time before and after merging. This is good but if this really badly affects our CI time we may probably want to revert still.
This change shouldn't affect CI time since the tasks run in parallel. Though I am seeinga "Task scheduling was delayed due to a concurrency limit on community tasks" warning It will likely double our budget. I'll try to confirm this by looking at the times manually. |
collinjackson
added a commit
to collinjackson/plugins
that referenced
this pull request
Oct 16, 2019
This reverts commit c155379.
collinjackson
added a commit
that referenced
this pull request
Oct 16, 2019
collinjackson
added a commit
to collinjackson/plugins
that referenced
this pull request
Oct 16, 2019
…"" This reverts commit 1162798.
collinjackson
added a commit
that referenced
this pull request
Oct 17, 2019
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…tter#2199) This reverts commit c155379.
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
* Revert "Revert "Enable testing on both master and stable (flutter#2197)"" This reverts commit 1162798. * Suppress testing of web plugins for now * Run all plugins on stable * Ignore deprecation warning in video player plugin
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…tter#2199) This reverts commit c155379.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
* Revert "Revert "Enable testing on both master and stable (flutter#2197)"" This reverts commit 1162798. * Suppress testing of web plugins for now * Run all plugins on stable * Ignore deprecation warning in video player plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR runs the Cirrus tests on both master and stable for most types of tests, with the exception of formatting and analyzer. The "build all plugins" test only being run on master, but that should be fixed in the future (flutter/flutter#42810).
Related Issues
Fixes flutter/flutter#42377