[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Enable testing on both master and stable #2197

Merged
merged 14 commits into from
Oct 16, 2019

Conversation

collinjackson
Copy link
Contributor
@collinjackson collinjackson commented Oct 15, 2019

Description

This PR runs the Cirrus tests on both master and stable for most types of tests, with the exception of formatting and analyzer. The "build all plugins" test only being run on master, but that should be fixed in the future (flutter/flutter#42810).

Related Issues

Fixes flutter/flutter#42377

Copy link
Contributor
@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor
@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good if we also tracked average CI time before and after merging. This is good but if this really badly affects our CI time we may probably want to revert still.

@collinjackson
Copy link
Contributor Author
collinjackson commented Oct 16, 2019

This change shouldn't affect CI time since the tasks run in parallel. Though I am seeinga "Task scheduling was delayed due to a concurrency limit on community tasks" warning

It will likely double our budget.

I'll try to confirm this by looking at the times manually.

@collinjackson collinjackson merged commit c155379 into flutter:master Oct 16, 2019
collinjackson added a commit to collinjackson/plugins that referenced this pull request Oct 16, 2019
collinjackson added a commit that referenced this pull request Oct 16, 2019
collinjackson added a commit to collinjackson/plugins that referenced this pull request Oct 16, 2019
collinjackson added a commit that referenced this pull request Oct 17, 2019
* Revert "Revert "Enable testing on both master and stable (#2197)""

This reverts commit 1162798.

* Suppress testing of web plugins for now
* Run all plugins on stable
* Ignore deprecation warning in video player plugin
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
* Revert "Revert "Enable testing on both master and stable (flutter#2197)""

This reverts commit 1162798.

* Suppress testing of web plugins for now
* Run all plugins on stable
* Ignore deprecation warning in video player plugin
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* Revert "Revert "Enable testing on both master and stable (flutter#2197)""

This reverts commit 1162798.

* Suppress testing of web plugins for now
* Run all plugins on stable
* Ignore deprecation warning in video player plugin
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants