[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[path_provider] Path provider docs need to be more cross-platform #76427

Closed
stuartmorgan opened this issue Feb 20, 2021 · 1 comment · Fixed by flutter/plugins#6989
Closed

[path_provider] Path provider docs need to be more cross-platform #76427

stuartmorgan opened this issue Feb 20, 2021 · 1 comment · Fixed by flutter/plugins#6989
Assignees
@stuartmorgan
Labels
p: path_provider Plugin that provides resolved paths to some platform directories P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.

Comments

@stuartmorgan
Copy link
Contributor

Currently the docs in the app-facing package document things in terms of their implementations on Android and iOS. We should either document all endorsed platforms' implementations, or just use generic documentation with a list of example implementations.
@stuartmorgan stuartmorgan added plugin p: path_provider Plugin that provides resolved paths to some platform directories P2 Important issues not at the top of the work list labels Feb 20, 2021
@stuartmorgan stuartmorgan self-assigned this Jan 18, 2023
@stuartmorgan stuartmorgan mentioned this issue Jan 19, 2023
Merged
11 tasks
auto-submit bot pushed a commit to flutter/plugins that referenced this issue Jan 19, 2023
@stuartmorgan
[path_provider] Switch to path_provider_foundation (#6989)
d348d44 
* [path_provider] Switch to `path_provider_foundation`

Switches to using the new combined `path_provider_foundation` for iOS
and macOS.

Also updates the code documentation to make it less Android and iOS
specific. The original goal was to make the documentation for
the download directory not be actively wrong for the new implementation,
but it seemed like a good time to fix 76427 more generally.
(The fact that the docs are kind of a mess because the API itself
is kind of a mess is now
flutter/flutter#118712.)

Fixes flutter/flutter#117941
Fixes flutter/flutter#76427

* Remove exclusion

* Update test expectations and README

* Update test expectations again, and update docs
mauricioluz pushed a commit to mauricioluz/plugins that referenced this issue Jan 26, 2023
@stuartmorgan @mauricioluz
[path_provider] Switch to path_provider_foundation (flutter#6989)
576f7e9 
* [path_provider] Switch to `path_provider_foundation`

Switches to using the new combined `path_provider_foundation` for iOS
and macOS.

Also updates the code documentation to make it less Android and iOS
specific. The original goal was to make the documentation for
the download directory not be actively wrong for the new implementation,
but it seemed like a good time to fix 76427 more generally.
(The fact that the docs are kind of a mess because the API itself
is kind of a mess is now
flutter/flutter#118712.)

Fixes flutter/flutter#117941
Fixes flutter/flutter#76427

* Remove exclusion

* Update test expectations and README

* Update test expectations again, and update docs
engine-flutter-autoroll pushed a commit to engine-flutter-autoroll/packages that referenced this issue Feb 22, 2023
@stuartmorgan
[path_provider] Switch to path_provider_foundation (flutter#6989)
acd195b 
* [path_provider] Switch to `path_provider_foundation`

Switches to using the new combined `path_provider_foundation` for iOS
and macOS.

Also updates the code documentation to make it less Android and iOS
specific. The original goal was to make the documentation for
the download directory not be actively wrong for the new implementation,
but it seemed like a good time to fix 76427 more generally.
(The fact that the docs are kind of a mess because the API itself
is kind of a mess is now
flutter/flutter#118712.)

Fixes flutter/flutter#117941
Fixes flutter/flutter#76427

* Remove exclusion

* Update test expectations and README

* Update test expectations again, and update docs
@github-actions
Copy link
github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stuartmorgan stuartmorgan

Labels
p: path_provider Plugin that provides resolved paths to some platform directories P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[path_provider] Switch to path_provider_foundation stuartmorgan/plugins
2 participants
@stuartmorgan @pedromassangocode