Upload DerivedData logs in CI #142643

vashworth · 2024-01-31T21:05:53Z

When the Dart VM is not found within 10 minutes in CI on CoreDevices (iOS 17+), stop the app and upload the logs from DerivedData. The app has to be stopped first since the logs are not put in DerivedData until it's stopped.

Also, rearranged some logic to have CoreDevice have its own function for Dart VM url discovery.

Debugging for #142448.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2024-01-31T23:49:29Z

packages/flutter_tools/lib/src/ios/devices.dart

+      maxWaitForCI = Timer(const Duration(minutes: 10), () async {
+        _logger.printError('Failed to find Dart VM after 10 minutes.');
+        await _xcodeDebug.exit();
+        final String? logsDirectoryPath = _platform.environment['FLUTTER_LOGS_DIR'];


I don't think we have any prior examples for putting the environment details of LUCI into the tool. In the past I've passed in the log location if the tool really needed to know about it #78822

@christopherfujino wdyt about this? I don't really like it in the public-facing tool but maybe I'm being arbitrary, but this repo does of course understand details about LUCI

flutter/dev/devicelab/lib/framework/host_agent.dart

Lines 23 to 33 in a1a801a

Directory? get dumpDirectory {

if (_dumpDirectory == null) {

// Set in LUCI recipe.

final String? directoryPath = _platform.environment['FLUTTER_LOGS_DIR'];

if (directoryPath != null) {

_dumpDirectory = _fileSystem.directory(directoryPath)..createSync(recursive: true);

print('Found FLUTTER_LOGS_DIR dump directory ${_dumpDirectory?.path}');

}

}

return _dumpDirectory;

}

previously where we needed this we would expose a new CLI option to the tool (for example --debug-logs-dir) and then provide them from the devicelab runner. This also might be generally useful for adding other debugging of this kind if and only if the --debug-logs-dir=$FLUTTER_LOGS_DIR option is passed.

Thanks for the feedback, I changed it to pass as a flag

jmagman · 2024-02-01T18:16:40Z

packages/flutter_tools/lib/src/ios/devices.dart

+                .childDirectory(entity.basename)
+                .childDirectory('Logs');
+            _logger.printTrace('Copying logs ${logsToCopy.path} to ${copyDestination.path}...');
+            copyDirectory(logsToCopy, copyDestination);


You may wind up needing to compress this before you copy it if you hit this problem #75736 :

I'm not sure how logs are handled these days, may as well merge this and see.

packages/flutter_tools/lib/src/ios/devices.dart

christopherfujino

LGTM

auto-submit · 2024-02-01T20:00:28Z

auto label is removed for flutter/flutter/142643, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…6053) Manual roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e02e207...0b5cd50 2024-02-05 124896814+BiskupMaik@users.noreply.github.com fix AppBar docs for backgroundColor & foregroundColor (flutter/flutter#142430) 2024-02-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update gradle lockfiles template" (flutter/flutter#142889) 2024-02-04 barpac02@gmail.com Update gradle lockfiles template (flutter/flutter#140115) 2024-02-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20742e37e54e to f34c658b9600 (1 revision) (flutter/flutter#142876) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23763db72272 to 20742e37e54e (1 revision) (flutter/flutter#142850) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fee02145da8c to 23763db72272 (3 revisions) (flutter/flutter#142848) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9869d47a2736 to fee02145da8c (2 revisions) (flutter/flutter#142847) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78c63d3c2c68 to 9869d47a2736 (1 revision) (flutter/flutter#142842) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 266d5d0b5588 to 78c63d3c2c68 (1 revision) (flutter/flutter#142836) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.2 to 3.24.0 (flutter/flutter#142839) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.6 to 4.0.1 (flutter/flutter#142838) 2024-02-02 jmccandless@google.com Update TextSelectionOverlay (flutter/flutter#142463) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e29263212bfd to 266d5d0b5588 (5 revisions) (flutter/flutter#142832) 2024-02-02 luccas.clezar@gmail.com Fix CupertinoTextSelectionToolbar clipping (flutter/flutter#138195) 2024-02-02 barpac02@gmail.com Reland "Add support for Gradle Kotlin DSL (#140744)" (flutter/flutter#142752) 2024-02-02 jmccandless@google.com Support navigation during a Cupertino back gesture (flutter/flutter#142248) 2024-02-02 chingjun@google.com Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (flutter/flutter#142760) 2024-02-02 engine-flutter-autoroll@skia.org Roll Packages from 5b48c44 to d37fb0a (14 revisions) (flutter/flutter#142812) 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/flutter#142765) 2024-02-02 15619084+vashworth@users.noreply.github.com Allow all iOS tests to use either iOS 16 or 17 (flutter/flutter#142714) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b35153d00b2e to e29263212bfd (2 revisions) (flutter/flutter#142799) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4c79a6c864 to b35153d00b2e (10 revisions) (flutter/flutter#142783) 2024-02-02 jacksongardner@google.com Wasm/JS Dual Compile with the flutter tool (flutter/flutter#141396) 2024-02-02 hans.muller@gmail.com Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (flutter/flutter#142762) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Use proto name for emulator version and show cipd package version (flutter/flutter#142262) 2024-02-01 xilaizhang@google.com [github actions] ping actor of workflow on cherry pick pr creation (flutter/flutter#142676) 2024-02-01 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#142590) 2024-02-01 nathan.wilson1232@gmail.com Implement `switch` expressions in `lib/src/material/` (flutter/flutter#142634) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9beb7e82e081 to dd4c79a6c864 (1 revision) (flutter/flutter#142749) 2024-02-01 pateltirth454@gmail.com Write Tests for API Example of `form.0.dart` (flutter/flutter#142635) 2024-02-01 polinach@google.com Make leak_tracking bots sticked to the left even if bot thinks they are non-flacky. (flutter/flutter#142744) 2024-02-01 15619084+vashworth@users.noreply.github.com Upload DerivedData logs in CI (flutter/flutter#142643) 2024-02-01 magder@google.com Test codesigning xcframeworks in artifacts (flutter/flutter#142666) 2024-02-01 davidmartos96@gmail.com Fix gen_defaults test randomness (flutter/flutter#142743) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder" (flutter/flutter#142748) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39415c3eed42 to 9beb7e82e081 (5 revisions) (flutter/flutter#142745) 2024-02-01 magder@google.com Remove unused deprecated autoroll mirror-remote flag (flutter/flutter#142738) 2024-02-01 polinach@google.com Fix leaks in tests. (flutter/flutter#142677) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c43332c6ffc to 39415c3eed42 (1 revision) (flutter/flutter#142740) 2024-02-01 magder@google.com Remove verbose-system-logs on iOS perf tests (flutter/flutter#142739) 2024-02-01 magder@google.com Remove outdated arm64_armv7 check (flutter/flutter#142737) 2024-02-01 62812903+sstasi95@users.noreply.github.com fix CupertinoTabView's Android back button handling with PopScope (flutter/flutter#141604) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68943afd62d1 to 8c43332c6ffc (8 revisions) (flutter/flutter#142726) 2024-02-01 christopherfujino@gmail.com Unpin test (flutter/flutter#141427) ...

…lutter#6053) Manual roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@e02e207...0b5cd50 2024-02-05 124896814+BiskupMaik@users.noreply.github.com fix AppBar docs for backgroundColor & foregroundColor (flutter/flutter#142430) 2024-02-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update gradle lockfiles template" (flutter/flutter#142889) 2024-02-04 barpac02@gmail.com Update gradle lockfiles template (flutter/flutter#140115) 2024-02-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20742e37e54e to f34c658b9600 (1 revision) (flutter/flutter#142876) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23763db72272 to 20742e37e54e (1 revision) (flutter/flutter#142850) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fee02145da8c to 23763db72272 (3 revisions) (flutter/flutter#142848) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9869d47a2736 to fee02145da8c (2 revisions) (flutter/flutter#142847) 2024-02-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78c63d3c2c68 to 9869d47a2736 (1 revision) (flutter/flutter#142842) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 266d5d0b5588 to 78c63d3c2c68 (1 revision) (flutter/flutter#142836) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.2 to 3.24.0 (flutter/flutter#142839) 2024-02-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.6 to 4.0.1 (flutter/flutter#142838) 2024-02-02 jmccandless@google.com Update TextSelectionOverlay (flutter/flutter#142463) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e29263212bfd to 266d5d0b5588 (5 revisions) (flutter/flutter#142832) 2024-02-02 luccas.clezar@gmail.com Fix CupertinoTextSelectionToolbar clipping (flutter/flutter#138195) 2024-02-02 barpac02@gmail.com Reland "Add support for Gradle Kotlin DSL (#140744)" (flutter/flutter#142752) 2024-02-02 jmccandless@google.com Support navigation during a Cupertino back gesture (flutter/flutter#142248) 2024-02-02 chingjun@google.com Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (flutter/flutter#142760) 2024-02-02 engine-flutter-autoroll@skia.org Roll Packages from 5b48c44 to d37fb0a (14 revisions) (flutter/flutter#142812) 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/flutter#142765) 2024-02-02 15619084+vashworth@users.noreply.github.com Allow all iOS tests to use either iOS 16 or 17 (flutter/flutter#142714) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from b35153d00b2e to e29263212bfd (2 revisions) (flutter/flutter#142799) 2024-02-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4c79a6c864 to b35153d00b2e (10 revisions) (flutter/flutter#142783) 2024-02-02 jacksongardner@google.com Wasm/JS Dual Compile with the flutter tool (flutter/flutter#141396) 2024-02-02 hans.muller@gmail.com Reland: Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder (flutter/flutter#142762) 2024-02-01 32242716+ricardoamador@users.noreply.github.com Use proto name for emulator version and show cipd package version (flutter/flutter#142262) 2024-02-01 xilaizhang@google.com [github actions] ping actor of workflow on cherry pick pr creation (flutter/flutter#142676) 2024-02-01 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#142590) 2024-02-01 nathan.wilson1232@gmail.com Implement `switch` expressions in `lib/src/material/` (flutter/flutter#142634) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9beb7e82e081 to dd4c79a6c864 (1 revision) (flutter/flutter#142749) 2024-02-01 pateltirth454@gmail.com Write Tests for API Example of `form.0.dart` (flutter/flutter#142635) 2024-02-01 polinach@google.com Make leak_tracking bots sticked to the left even if bot thinks they are non-flacky. (flutter/flutter#142744) 2024-02-01 15619084+vashworth@users.noreply.github.com Upload DerivedData logs in CI (flutter/flutter#142643) 2024-02-01 magder@google.com Test codesigning xcframeworks in artifacts (flutter/flutter#142666) 2024-02-01 davidmartos96@gmail.com Fix gen_defaults test randomness (flutter/flutter#142743) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added ButtonStyle.foregroundBuilder and ButtonStyle.backgroundBuilder" (flutter/flutter#142748) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39415c3eed42 to 9beb7e82e081 (5 revisions) (flutter/flutter#142745) 2024-02-01 magder@google.com Remove unused deprecated autoroll mirror-remote flag (flutter/flutter#142738) 2024-02-01 polinach@google.com Fix leaks in tests. (flutter/flutter#142677) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8c43332c6ffc to 39415c3eed42 (1 revision) (flutter/flutter#142740) 2024-02-01 magder@google.com Remove verbose-system-logs on iOS perf tests (flutter/flutter#142739) 2024-02-01 magder@google.com Remove outdated arm64_armv7 check (flutter/flutter#142737) 2024-02-01 62812903+sstasi95@users.noreply.github.com fix CupertinoTabView's Android back button handling with PopScope (flutter/flutter#141604) 2024-02-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68943afd62d1 to 8c43332c6ffc (8 revisions) (flutter/flutter#142726) 2024-02-01 christopherfujino@gmail.com Unpin test (flutter/flutter#141427) ...

vashworth added 2 commits January 31, 2024 14:59

Upload logs when fails to find Dart VM in CI

f70386d

remove unused code

214cd22

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 31, 2024

vashworth requested a review from jmagman January 31, 2024 22:00

jmagman reviewed Jan 31, 2024

View reviewed changes

vashworth added 2 commits February 1, 2024 11:14

Pass FLUTTER_LOGS_DIR as a flag instead of using environment variable

8690e4f

fix help description

270814e

jmagman approved these changes Feb 1, 2024

View reviewed changes

christopherfujino reviewed Feb 1, 2024

View reviewed changes

packages/flutter_tools/lib/src/ios/devices.dart Show resolved Hide resolved

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2024

christopherfujino approved these changes Feb 1, 2024

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2024

Merge branch 'master' into upload_derived_data_logs_in_ci

1755a96

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2024

auto-submit bot merged commit e5c286e into flutter:master Feb 1, 2024
137 checks passed

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to 6cc4edb96f4e (25 revisions) flutter/packages#6036

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

ecf2816

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to 10e6f4bd6077 (26 revisions) flutter/packages#6037

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

e451069

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to 3f30dc2e0a39 (28 revisions) flutter/packages#6039

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

fef12c7

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to b209125d11af (29 revisions) flutter/packages#6040

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

653cd4b

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Roll Flutter from e02e2079bea7 to ac7879e2aa6d (30 revisions) flutter/packages#6041

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

5734fe2

engine-flutter-autoroll mentioned this pull request Feb 2, 2024

Manual roll Flutter from e02e2079bea7 to ac7879e2aa6d (30 revisions) flutter/packages#6042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

3a0955e

engine-flutter-autoroll mentioned this pull request Feb 3, 2024

Roll Flutter from e02e2079bea7 to f6fb563b15be (42 revisions) flutter/packages#6045

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

f5cec12

engine-flutter-autoroll mentioned this pull request Feb 3, 2024

Roll Flutter from e02e2079bea7 to f6fb563b15be (42 revisions) flutter/packages#6046

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

fc2ce13

engine-flutter-autoroll mentioned this pull request Feb 4, 2024

Roll Flutter from e02e2079bea7 to f8a77225f360 (45 revisions) flutter/packages#6047

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

4a38875

engine-flutter-autoroll mentioned this pull request Feb 4, 2024

Roll Flutter from e02e2079bea7 to f8a77225f360 (45 revisions) flutter/packages#6048

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

3a0d801

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6052

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

cf99a59

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Manual roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6053

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

58b981a

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to 0b5cd5073a3b (46 revisions) flutter/packages#6054

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

9d07263

engine-flutter-autoroll mentioned this pull request Feb 5, 2024

Roll Flutter from e02e2079bea7 to cbc18b2c51ca (47 revisions) flutter/packages#6055

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

29033bc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

e5c286e02 Upload DerivedData logs in CI (flutter/flutter#142643)

e876df5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload DerivedData logs in CI #142643

Upload DerivedData logs in CI #142643

	Directory? get dumpDirectory {
	if (_dumpDirectory == null) {
	// Set in LUCI recipe.
	final String? directoryPath = _platform.environment['FLUTTER_LOGS_DIR'];
	if (directoryPath != null) {
	_dumpDirectory = _fileSystem.directory(directoryPath)..createSync(recursive: true);
	print('Found FLUTTER_LOGS_DIR dump directory ${_dumpDirectory?.path}');
	}
	}
	return _dumpDirectory;
	}

Upload DerivedData logs in CI #142643

Upload DerivedData logs in CI #142643

Conversation

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment