[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default flutter source directory for gradle builds #142934

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Set default flutter source directory for gradle builds #142934

merged 3 commits into from
Feb 8, 2024

Conversation

Gustl22
Copy link
Contributor
@Gustl22 Gustl22 commented Feb 5, 2024

See #142498
See this discussion: https://discord.com/channels/608014603317936148/1186378330178601000

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 5, 2024
@Gustl22 Gustl22 mentioned this pull request Feb 5, 2024
Merged
8 tasks
@Gustl22
Copy link
Contributor Author
Gustl22 commented Feb 5, 2024

Cc @reidbaker @bartekpacia

christopherfujino
christopherfujino approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member
@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 8, 2024
@auto-submit auto-submit bot merged commit 2299ec7 into flutter:master Feb 8, 2024
125 checks passed
@Gustl22 Gustl22 deleted the 142498-default-flutter-source-path branch February 9, 2024 00:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
f754b05 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
d103891 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
8b53cf4 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
81cf2db 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
da22ea5 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
cfa225e 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
d4f1fca 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
e9d8779 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
e8cfccb 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
3cf554c 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
0700305 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
77fd973 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
0097e46 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
7d0714f 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
336ff58 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
17af136 
…tter/flutter#142934)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
087e7e9 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
d9c4aed 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
773dd52 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
64c401b 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
6269557 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
668c24f 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
ee54873 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
1f8a6f4 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
c2ecbbc 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
9deb441 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
3e9dc11 
…tter/flutter#142934)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
2299ec781 Set default flutter source directory for gradle builds (flu…
fdaca10 
…tter/flutter#142934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gustl22 @reidbaker @christopherfujino