[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cirrus check for web test concurrency #143046

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Remove Cirrus check for web test concurrency #143046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions dev/bots/test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2285,8 +2285,6 @@ Future<void> _runFlutterWebTest(String webRenderer, String workingDirectory, Lis
flutter,
<String>[
'test',
if (ciProvider == CiProviders.cirrus)
'--concurrency=1', // do not parallelize on Cirrus, to reduce flakiness
'-v',
'--platform=chrome',
'--web-renderer=$webRenderer',
Expand Down Expand Up @@ -2482,21 +2480,6 @@ void adjustEnvironmentToEnableFlutterAsserts(Map<String, String> environment) {
environment['FLUTTER_TOOL_ARGS'] = toolsArgs.trim();
}

enum CiProviders {
cirrus,
luci,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last usage removed with #142736

}

CiProviders? get ciProvider {
if (Platform.environment['CIRRUS_CI'] == 'true') {
return CiProviders.cirrus;
}
if (Platform.environment['LUCI_CONTEXT'] != null) {
return CiProviders.luci;
}
return null;
}

/// Checks the given file's contents to determine if they match the allowed
/// pattern for version strings.
///
Expand Down