[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts "Platform view devicelab ad banner scroll list real ads (#144745)" #145189

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Reverts "Platform view devicelab ad banner scroll list real ads (#144745)" #145189

merged 1 commit into from
Mar 15, 2024

Conversation

auto-submit[bot]
Copy link
Contributor
@auto-submit auto-submit bot commented Mar 15, 2024

Reverts: #144745

Initiated by: gspencergoog

Reason for reverting: appears to have broken the build.

Original PR Author: hellohuanlin

Reviewed By: {jmagman, jonahwilliams}

This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement.

It is similar to https://github.com/lucalooz/flutter_ads_list_perf

There's still a pending issue #144339

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Fixes #143534
Fixes #143257

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 15, 2024
@github-actions github-actions bot added the f: scrolling Viewports, list views, slivers, etc. label Mar 15, 2024
@auto-submit auto-submit bot merged commit 7f1c93d into master Mar 15, 2024
7 of 9 checks passed
@auto-submit auto-submit bot deleted the revert_be78542d6c2a7ff96f2f277fd9fa7a966c15a152 branch March 15, 2024 00:21
@hellohuanlin
Copy link
Contributor
hellohuanlin commented Mar 15, 2024 •
edited
Loading

The issue seems to be related to Android. Not sure if this is related to the fact that I added admob dependency. May need some help from android folks (cc @gmackall)

https://ci.chromium.org/p/flutter/builders/prod/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/1661

 > Task :app:checkProfileAarMetadata FAILED
[2024-03-14 14:51:59.425445] [STDOUT] stderr: [        ] FAILURE: Build failed with an exception.
[2024-03-14 14:51:59.426001] [STDOUT] stderr: [        ] * What went wrong:
[2024-03-14 14:51:20.558971] [STDOUT] stderr: [        ] Execution failed for task ':app:checkProfileAarMetadata'.
[2024-03-14 14:51:20.559361] [STDOUT] stderr: [        ] > Could not resolve all files for configuration ':app:profileRuntimeClasspath'.

...

Gradle task assembleProfile failed with exit code 1
[2024-03-14 14:52:01.455943] [STDOUT] stderr: [   +1 ms] 
[2024-03-14 14:52:01.456046] [STDOUT] stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
[2024-03-14 14:52:01.459512] [STDOUT] stderr:            #1      AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:542:7)
[2024-03-14 14:52:01.459625] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.459682] [STDOUT] stderr:            #2      AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:223:5)
[2024-03-14 14:52:01.459738] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.459793] [STDOUT] stderr:            #3      AndroidDevice.startApp (package:flutter_tools/src/android/android_device.dart:583:7)
[2024-03-14 14:52:01.459846] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.459901] [STDOUT] stderr:            #4      FlutterDriverService.start (package:flutter_tools/src/drive/drive_service.dart:178:16)
[2024-03-14 14:52:01.460056] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.460131] [STDOUT] stderr:            #5      DriveCommand.runCommand (package:flutter_tools/src/commands/drive.dart:273:9)
[2024-03-14 14:52:01.460201] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.460273] [STDOUT] stderr:            #6      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1394:27)
[2024-03-14 14:52:01.460357] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.460427] [STDOUT] stderr:            #7      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
[2024-03-14 14:52:01.460519] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.460603] [STDOUT] stderr:            #8      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
[2024-03-14 14:52:01.460711] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.460780] [STDOUT] stderr:            #9      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:360:9)
[2024-03-14 14:52:01.460850] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.461042] [STDOUT] stderr:            #10     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
[2024-03-14 14:52:01.461125] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.461195] [STDOUT] stderr:            #11     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:300:5)
[2024-03-14 14:52:01.461271] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.461325] [STDOUT] stderr:            #12     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:119:9)
[2024-03-14 14:52:01.461379] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.461454] [STDOUT] stderr:            #13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
[2024-03-14 14:52:01.461510] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.461569] [STDOUT] stderr:            #14     main (package:flutter_tools/executable.dart:94:3)
[2024-03-14 14:52:01.461699] [STDOUT] stderr:            <asynchronous suspension>
[2024-03-14 14:52:01.461782] [STDOUT] stderr:

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
68b7321 
… ads (#144745)" (flutter/flutter#145189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
a3b64f1 
… ads (#144745)" (flutter/flutter#145189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
b043f8d 
… ads (#144745)" (flutter/flutter#145189)
@gmackall
Copy link
Member

Looks like a lockfile issue to me, let me try running building that benchmark app with your PR + lockfiles re-generated

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
@gmackall
Copy link
Member
gmackall commented Mar 15, 2024 •
edited
Loading

7be30f3 fixes for me (I didn't try exactly what the test was doing but apk build fails before and succeeds after).

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
9908656 
… ads (#144745)" (flutter/flutter#145189)
@hellohuanlin
Copy link
Contributor

7be30f3 fixes for me (I didn't try exactly what the test was doing but apk build fails before and succeeds after)

May i know what command did you run? Thansk!

@gmackall
Copy link
Member
gmackall commented Mar 15, 2024 •
edited
Loading

7be30f3 fixes for me (I didn't try exactly what the test was doing but apk build fails before and succeeds after)

May i know what command did you run? Thansk!

It's the partial output of running the generate_gradle_lockfiles.dart script on the dev/benchmarks/platform_views_layout/android directory. Partial because it is only the change to the existing lockfile, I deleted the newly created files, because I don't know the entire context of why we started making these lockfiles in the first place (I think no one does at this point) and I suspect we should avoid adding more of them.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
5c54b5f 
… ads (#144745)" (flutter/flutter#145189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
bd26d1c 
… ads (#144745)" (flutter/flutter#145189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
1de832b 
… ads (#144745)" (flutter/flutter#145189)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
9eb71b7 
… ads (#144745)" (flutter/flutter#145189)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
7f1c93d73 Reverts "Platform view devicelab ad banner scroll list real…
484c44a 
… ads (#144745)" (flutter/flutter#145189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@gspencergoog gspencergoog

Labels
f: scrolling Viewports, list views, slivers, etc. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Milestone
No milestone
4 participants
@hellohuanlin @gmackall @fluttergithubbot @gspencergoog