Refactor how we handle errors around imgtestInit/tryjobInit #149356
+205
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we don't really assert that these aren't called in ways that conflict with their internal logic, and that there were some redundant initializers and some race conditions. This patch makes it so that calling them reentrantly is always safe and always returns the same future, while also explicitly asserting that they're not called in conflicting ways.
|
Not really part of my ongoing refactor, just something I ran into while trying to figure out what to do next in that refactor. |
Piinks
reviewed
Jun 13, 2024
| // because the FakeProcessManager we use never returns. | ||
| // Using a synchronous try/catch works because the assertion is not asynchronous. | ||
| client.tryjobInit(); | ||
| fail('Missing assertion.'); |
There was a problem hiding this comment.
In my experience, we usually avoid these types of try/fail tests since folks tend to forget to add the fail at the end of the try block. Can these be updated to something like this test instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we don't really assert that these aren't called in ways that conflict with their internal logic, and that there were some redundant initializers and some race conditions. This patch makes it so that calling them reentrantly is always safe and always returns the same future, while also explicitly asserting that they're not called in conflicting ways.
Diff is much more readable if you enable "ignore whitespace changes".