[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for elevation in refresh indicator. #149796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for elevation in refresh indicator. #149796

wants to merge 2 commits into from
+8 −0

Conversation

dishankjindal1
Copy link
@dishankjindal1 dishankjindal1 commented Jun 6, 2024 •
edited
Loading

Refresh Indicator Elevation:

  • Added elevation to the refresh indicator using elevation attribute.
  • This change improves the indicator's visibility against various background colors and enhances overall UI consistency.
  • If we want to get rid of shadow effect from the indicator itself.

The refresh indicator did not provide the control over depth of the progress indicator. This change addresses that issue by adding elevation to the indicator, creating a subtle depth effect that makes it more visually prominent and provides better feedback to the user.

No breaking changes.

before

after

Pre-launch Checklist

  • [yes] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [yes] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [yes] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [yes] I signed the [CLA].
  • [yes] I listed at least one issue that this PR fixes in the description above.
  • [yes] I updated/added relevant documentation (doc comments with ///).
  • [yes] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [yes] I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • [yes] All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla Google CLA
Copy link
google-cla bot commented Jun 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 6, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149796 at sha 99f6733

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 12, 2024
MitchellGoodwin
MitchellGoodwin reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor
@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This will need a test to protect against future regressions. Just a simple test that checks if the elevation is the expected value both by default and when using a custom value. Also, I'm not sure why the golden test failed before, we'll have to keep an eye on that.

packages/flutter/lib/src/material/refresh_indicator.dart
@@ -591,6 +598,7 @@ class RefreshIndicatorState extends State<RefreshIndicator> with TickerProviderS
valueColor: _valueColor,
backgroundColor: widget.backgroundColor,
strokeWidth: widget.strokeWidth,
elevation: widget.elevation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nit: some extra space here. elevation needs to be lined up with the other proerties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchellGoodwin MitchellGoodwin MitchellGoodwin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dishankjindal1 @MitchellGoodwin