-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ComputedNotifier
streaming class
#150143
Open
HenriqueNas
wants to merge
8
commits into
flutter:master
Choose a base branch
from
HenriqueNas:feature/change_notifier
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+224
−1
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0dfdd16
feat: Introduce `ComputedNotifier` for derived state management
HenriqueNas c6ce9e8
test: create group of test for `ComputedNotifier` class
HenriqueNas ff30c0d
Docs: Include `ComputedNotifier` in preferred listeners
HenriqueNas 1e4c906
test: ensure `ComputedNotifier` handles disposed listenables
HenriqueNas 23d6421
revert: undo unrelated code formatting
HenriqueNas 8ffc1a1
revert: undo spacing formatting
HenriqueNas 9ce230a
doc: apply doc fixing for `ComputedNotifier` class
HenriqueNas 4a6c5fd
Merge branch 'master' into feature/change_notifier
HenriqueNas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: apply doc fixing for
ComputedNotifier
class
- Loading branch information
commit 9ce230a2467749a8d94b11be1abd0c65489fa95a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What worries me about this API design: It's gonna be very easy to use a listenable in the compute function and accidentally forget to include it in the listenable list...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right!! But although I think it might happen, I am not very worried about that.. It's a basic programming skill issue, not very related to the API signature.
Also, in some cases, you might not want to include all values used in the computed callback in your listenable list, right?
But, what do you think we can do to improve it? Besides a clear documentation..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can return the listenable list as a parameter in our callback, so it can reinforces the user to add the listenable to the list:
To be honest, I do not found this a good solution. Maybe because I don't see it as a ruge problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made me intriguer about a solution for this... what do you think about write the API as this?