-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transparent dividerColor
breaks TabBar.tabAlignment
#150350
Fix transparent dividerColor
breaks TabBar.tabAlignment
#150350
Conversation
dividerColor
breaks TabBar. tabAlignment
dividerColor
breaks TabBar.tabAlignment
b06afd9
to
66b7844
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a question about a comment you added.
@@ -1814,7 +1818,7 @@ class _TabBarState extends State<TabBar> { | |||
|
|||
final Color dividerColor = widget.dividerColor ?? tabBarTheme.dividerColor ?? _defaults.dividerColor!; | |||
final double dividerHeight = widget.dividerHeight ?? tabBarTheme.dividerHeight ?? _defaults.dividerHeight!; | |||
final bool showDivider = dividerColor != Colors.transparent && dividerHeight > 0; | |||
final bool showDivider = dividerHeight > 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the first comment you added above is not true, right? The divider will still be drawn even when it is transparent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch! You're right, this needs to be separate conditions. I just updated, the divider isn't drawn now when divider color is transparent.
4cf32ce
to
793e438
Compare
793e438
to
13c1dc1
Compare
Resolved test class conflict from another of my |
…6954) Manual roll requested by stuartmorgan@google.com flutter/flutter@ccf3abe...6c06abb 2024-06-18 magder@google.com Add test for engine artifact framework permissions (flutter/flutter#148786) 2024-06-18 32538273+ValentinVignal@users.noreply.github.com Add test for icon_button.3.dart (flutter/flutter#149988) 2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78fdd06af541 to 74f42ca3544c (6 revisions) (flutter/flutter#150421) 2024-06-18 tessertaha@gmail.com Fix transparent `dividerColor` breaks `TabBar.tabAlignment` (flutter/flutter#150350) 2024-06-18 tessertaha@gmail.com Fix scrollable `TabBar` jittering (flutter/flutter#150041) 2024-06-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: [CupertinoActionSheet] Match colors to native (#150386)" (flutter/flutter#150413) 2024-06-18 jason-simmons@users.noreply.github.com Extend the Windows web_tool_tests_1_2 shard timeout to 45 minutes (flutter/flutter#150393) 2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4e5e230ecb to 78fdd06af541 (3 revisions) (flutter/flutter#150403) 2024-06-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from a4f266f7eb1a to 1c4e5e230ecb (8 revisions) (flutter/flutter#150399) 2024-06-18 parlough@gmail.com Rename doc file to use standard hyphens (flutter/flutter#150314) 2024-06-17 120297255+PurplePolyhedron@users.noreply.github.com Fix typo in `SliverLayoutDimensions.hashCode` where not all properties are used in the hash code. (flutter/flutter#150306) 2024-06-17 srawlins@google.com Fix doc comment references to 'this' (flutter/flutter#150379) 2024-06-17 Lexycon@users.noreply.github.com Add 'fail-fast' argument to flutter test (flutter/flutter#149587) 2024-06-17 dev@alestiago.com Update matchesGoldenFile documentation reference to goldenFileComparator (flutter/flutter#150343) 2024-06-17 dkwingsmt@users.noreply.github.com Reland 3: [CupertinoActionSheet] Match colors to native (flutter/flutter#150386) 2024-06-17 jhy03261997@gmail.com [a11y] Add semantics: button to bottom navigation bar items and dropdown menu items (flutter/flutter#149375) 2024-06-17 yinxulolol@gmail.com Reland "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149720) 2024-06-17 36861262+QuncCccccc@users.noreply.github.com `ScaffoldBackgroundColor` should default to `ColorScheme.surface` (flutter/flutter#149772) 2024-06-17 katelovett@google.com Reland TreeSliver (flutter/flutter#149839) 2024-06-17 dkwingsmt@users.noreply.github.com Reland: [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#150219) 2024-06-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5989f0215fed to a4f266f7eb1a (1 revision) (flutter/flutter#150377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes
TabBar.tabAlignment
property does't work whendividerColor
is transparentCode sample
expand to view the code sample
Before (
dividerColor: Colors.transparent
,tabAlignment: TabAlignment.start
)After (
dividerColor: Colors.transparent
,tabAlignment: TabAlignment.start
)Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.