[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #150048 Autocomplete don't hide options when keyboardDismissBehavior: ScrollViewKeyboardDismissBehavior.onDrag on desktop #150317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

closes #150048 Autocomplete don't hide options when keyboardDismissBehavior: ScrollViewKeyboardDismissBehavior.onDrag on desktop #150317

wants to merge 2 commits into from
+42 −1

Conversation

D-extremity
Copy link
Contributor
@D-extremity D-extremity commented Jun 16, 2024 •
edited
Loading

In windowsx Linux, MacOs ScrollController().position.pixels will not recognize mouse pointer or scroll wheel of mouse if it's scrolled or not until its tapped on screen.
but for feature we just need to check if focus if there or not.

Now it is working for android,website,windows,macos and linux
closes #150048

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Jun 16, 2024
@D-extremity
Copy link
Contributor Author
D-extremity commented Jun 18, 2024 •
edited
Loading

@justinmc @huycozy please review it when you have time

@goderbauer goderbauer requested a review from justinmc June 18, 2024 22:03
@D-extremity
fixed Autocomplete don't hide options when keyboardDismissBehavior: S…
336f184 
…crollViewKeyboardDismissBehavior.onDrag on desktop flutter#150048
@D-extremity
Autocomplete hide options now irrespective of platform if keyboardDis…
7833e38 
…missBehaviour is set to ScrollViewKeyboardDismissBehavior.onDrag
@D-extremity
Copy link
Contributor Author

@justinmc please review it in your feasible time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc Awaiting requested review from justinmc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
1 participant
@D-extremity