Add tests for color_filtered.0.dart example. #151064

ksokolovskyi · 2024-06-30T11:36:06Z

This PR contributes to #130459

Description

Adds tests for examples/api/lib/widgets/color_filter/color_filtered.0.dart

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

TahaTesser · 2024-07-01T15:40:58Z

examples/api/test/widgets/color_filter/color_filtered.0_test.dart

+    HttpOverrides.global = null;
+  });
+
+  testWidgets('Displays two images', (WidgetTester tester) async {


These 3 tests can be just one clear and concise test.

"'Displays two images" test - you're already finding first and last images the implies there are only two images.

"'Applies red color filter with modulate blend mode to the first image" & "Applies grey color filter with saturation blend mode to the second image" - These two are short and verbose tests. We can add single test with "Color filter is applied to the images" and explain the difference in the test comment instead.

@TahaTesser thanks for the review and great suggestion. I applied it in the latest commit.

TahaTesser · 2024-07-01T15:49:10Z

examples/api/test/widgets/color_filter/color_filtered.0_test.dart


-    final RenderObject renderObject = tester.firstRenderObject(
+    final RenderObject renderObject1 = tester.firstRenderObject(


We can remove final and reassign the value, this also ensures that we have updated expected values.

Sorry, maybe I am missing something, but how does this ensure we have updated the expected values?

TahaTesser · 2024-07-01T15:49:21Z

examples/api/test/widgets/color_filter/color_filtered.0_test.dart

      find.byType(ColorFiltered).first,
    );
-    final ColorFilterLayer colorFilterLayer =
-        renderObject.debugLayer! as ColorFilterLayer;
+    final ColorFilterLayer colorFilterLayer1 =


We can remove final and reassign the value, this also ensures that we have updated expected values.

TahaTesser · 2024-07-01T15:55:13Z

examples/api/test/widgets/color_filter/color_filtered.0_test.dart

+    // Verify that two images are displayed.
+    expect(find.byType(Image), findsNWidgets(2));
+
+    final RenderObject renderObject1 = tester.firstRenderObject(


Suggested change

final RenderObject renderObject1 = tester.firstRenderObject(

RenderObject renderObject = tester.firstRenderObject(

TahaTesser · 2024-07-01T15:56:00Z

examples/api/test/widgets/color_filter/color_filtered.0_test.dart

+      equals(const ColorFilter.mode(Colors.red, BlendMode.modulate)),
+    );
+
+    final RenderObject renderObject2 = tester.firstRenderObject(


Suggested change

final RenderObject renderObject2 = tester.firstRenderObject(

renderObject = tester.firstRenderObject(

Earlier we found render object for the first image, here we assign the variable to expect a different value.

TahaTesser

LGTM

bleroux

LGTM!

ksokolovskyi · 2024-07-06T07:30:36Z

@TahaTesser @bleroux thanks for the review!

This PR contributes to flutter#130459 ### Description - Adds tests for `examples/api/lib/widgets/color_filter/color_filtered.0.dart`

…er#151064)

This PR contributes to flutter#130459 ### Description - Adds tests for `examples/api/lib/widgets/color_filter/color_filtered.0.dart`

…er#151064)

flutter/flutter@fafd67d...5103d75 2024-07-09 andrewrkolos@gmail.com [tool] Remove some usages of deprecated usage package (flutter/flutter#151359) 2024-07-09 43759233+kenzieschmoll@users.noreply.github.com Write the package config location to the test bootstrap. (flutter/flutter#150440) 2024-07-09 dacoharkes@google.com [deps] Roll dart-lang/native packages (flutter/flutter#151403) 2024-07-08 andrewrkolos@gmail.com [tool] make `testUsingContext` provide a `Stdio` (with `hasTerminal` unset) override by default (flutter/flutter#151357) 2024-07-08 120297255+PurplePolyhedron@users.noreply.github.com Make `FittedBox` not throw when child has zero size. (flutter/flutter#150430) 2024-07-08 nate.w5687@gmail.com Update `DataTable` documentation (flutter/flutter#151356) 2024-07-08 nate.w5687@gmail.com `MaterialState` â�� `WidgetState` in documentation (flutter/flutter#151376) 2024-07-08 41930132+hellohuanlin@users.noreply.github.com [ios]A typical news app benchmark with bottom ad banner (flutter/flutter#150991) 2024-07-08 gspencergoog@users.noreply.github.com Re-enable `SemanticsAction.focus` matchers (flutter/flutter#150990) 2024-07-08 hans.muller@gmail.com Added SliverFloatingHeader.snapMode (flutter/flutter#151289) 2024-07-08 nate.w5687@gmail.com Factor out deprecated names in example code (flutter/flutter#151374) 2024-07-08 cedvandenbosch@gmail.com Add cedric vanden bosch to authors (flutter/flutter#151313) 2024-07-08 engine-flutter-autoroll@skia.org Roll Packages from 97bad7e to 14341d1 (5 revisions) (flutter/flutter#151417) 2024-07-08 srawlins@google.com Update doc-import to primary configured import, _goldens_io.dart (flutter/flutter#151390) 2024-07-08 tessertaha@gmail.com [Reland] - Enable `explicitChildNodes` for the `AlertDialog` content (flutter/flutter#149597) 2024-07-08 32538273+ValentinVignal@users.noreply.github.com Add tests for material_state_border_side.0_test.dart (flutter/flutter#151089) 2024-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca79a56a66d7 to 69075e7e87d4 (1 revision) (flutter/flutter#151393) 2024-07-08 32538273+ValentinVignal@users.noreply.github.com Add tests for action_listener.0.dart (flutter/flutter#150606) 2024-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5ca3b856ee5a to ca79a56a66d7 (1 revision) (flutter/flutter#151387) 2024-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3600ec613a00 to 5ca3b856ee5a (1 revision) (flutter/flutter#151378) 2024-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d1ebc5fde630 to 3600ec613a00 (1 revision) (flutter/flutter#151377) 2024-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from e6b09697df1a to d1ebc5fde630 (1 revision) (flutter/flutter#151362) 2024-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/flutter#151354) 2024-07-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ee09d3b7f3b to e6b09697df1a (2 revisions) (flutter/flutter#151352) 2024-07-05 sokolovskyi.konstantin@gmail.com Add tests for color_filtered.0.dart example. (flutter/flutter#151064) 2024-07-05 christopherfujino@gmail.com de-duplicate code in analyze.dart (flutter/flutter#151279) 2024-07-05 engine-flutter-autoroll@skia.org Roll Packages from 754de19 to 97bad7e (1 revision) (flutter/flutter#151350) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 30, 2024

TahaTesser requested review from bleroux and TahaTesser July 1, 2024 15:36

TahaTesser requested changes Jul 1, 2024

View reviewed changes

ksokolovskyi requested a review from TahaTesser July 1, 2024 15:48

TahaTesser requested changes Jul 1, 2024

View reviewed changes

ksokolovskyi requested a review from TahaTesser July 1, 2024 16:02

ksokolovskyi force-pushed the add-color-filtered-example-tests branch 3 times, most recently from b957b99 to 7a8e7b7 Compare July 1, 2024 21:17

TahaTesser approved these changes Jul 2, 2024

View reviewed changes

ksokolovskyi force-pushed the add-color-filtered-example-tests branch 2 times, most recently from 23c769e to 531d935 Compare July 2, 2024 17:43

bleroux approved these changes Jul 3, 2024

View reviewed changes

ksokolovskyi added 3 commits July 3, 2024 14:02

Add tests for color_filtered.0.dart example.

c389d22

Apply review suggestions.

b03b4fa

Apply review suggestions.

974bfa2

ksokolovskyi force-pushed the add-color-filtered-example-tests branch from 531d935 to 974bfa2 Compare July 3, 2024 12:02

ksokolovskyi added 4 commits July 3, 2024 15:41

Merge branch 'master' into add-color-filtered-example-tests

eb1e1c4

Merge branch 'master' into add-color-filtered-example-tests

6e321b3

Merge branch 'master' into add-color-filtered-example-tests

f75567b

Merge branch 'master' into add-color-filtered-example-tests

6a6a49a

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2024

auto-submit bot merged commit bff1568 into flutter:master Jul 5, 2024
138 checks passed

engine-flutter-autoroll mentioned this pull request Jul 8, 2024

Roll Flutter from fafd67d34d68 to 3cffdf6c438a (12 revisions) flutter/packages#7074

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2024

bff15689f Add tests for color_filtered.0.dart example. (flutter/flutt…

70423ee

…er#151064)

engine-flutter-autoroll mentioned this pull request Jul 8, 2024

Roll Flutter from fafd67d34d68 to f0801023506f (13 revisions) flutter/packages#7075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2024

bff15689f Add tests for color_filtered.0.dart example. (flutter/flutt…

c771dae

…er#151064)

engine-flutter-autoroll mentioned this pull request Jul 8, 2024

Roll Flutter from fafd67d34d68 to 0a4f1a7e556e (16 revisions) flutter/packages#7076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2024

bff15689f Add tests for color_filtered.0.dart example. (flutter/flutt…

18476b7

…er#151064)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter from fafd67d34d68 to 9ab8b6e15043 (25 revisions) flutter/packages#7082

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024

bff15689f Add tests for color_filtered.0.dart example. (flutter/flutt…

22b8446

…er#151064)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter from fafd67d34d68 to 5ebc993dffe8 (26 revisions) flutter/packages#7083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024

bff15689f Add tests for color_filtered.0.dart example. (flutter/flutt…

f917395

…er#151064)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter from fafd67d34d68 to 5103d7574361 (27 revisions) flutter/packages#7084

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024

bff15689f Add tests for color_filtered.0.dart example. (flutter/flutt…

baf6311

…er#151064)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for color_filtered.0.dart example. #151064

Add tests for color_filtered.0.dart example. #151064


		final RenderObject renderObject = tester.firstRenderObject(
		final RenderObject renderObject1 = tester.firstRenderObject(

	final RenderObject renderObject1 = tester.firstRenderObject(
	RenderObject renderObject = tester.firstRenderObject(

	final RenderObject renderObject2 = tester.firstRenderObject(
	renderObject = tester.firstRenderObject(

Add tests for color_filtered.0.dart example. #151064

Add tests for color_filtered.0.dart example. #151064

Conversation

Description

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment