Add a simple convenience test task runner for VSCode #15417
Conversation
|
|
||
| if [[ "$1" == packages/flutter/test/* ]]; then | ||
| cd packages/flutter | ||
| ../../bin/flutter test ../../$1 |
There was a problem hiding this comment.
Are these paths correct? Seems strange that one starts with bin but the other ../../bin when they both refer to the same bin folder? (I'm on Windows so can't test atm...)
I could try making a Windows version of the script, but, I think when we do Dart-Code/Dart-Code#499 this might all get much simpler (needs a little investigation) and won't require maintaining a shell script like that.
There was a problem hiding this comment.
the flutter execution needs to be run in the directory with the pubspec.yaml.
the dart executable can just be run from the flutter repo root.
Mostly just a convenience script for us for now. Dart-Code/Dart-Code#499 is definitely a superior solution.
There was a problem hiding this comment.
Oh wow, I missed the cd on the line before... Monday morning!
LGTM then! If I end up working in here from Windows before Dart-Code/Dart-Code#499 I might create a Windows .bat equiv, but I hope the tasks isn't too far off!
|
I don't think we should add this file to the repo. It's IDE-specific. This means it won't be tested, it'll get out of sync, it's an additional maintenance burden on everyone who doesn't use that IDE, etc. We should be going the other direction instead, removing IDE-specific files and having the IDEs use a common file to configure themselves. |
|
Seems valid. In the future Dart Code should be able to help run tests without any/much config, but it's not there yet ( |
…#15417)" (flutter#15705) This reverts commit c8fd99f.
No description provided.