-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict-casts (as replacement for implicit-casts) #101567
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
/cc @srawlins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,8 +1,5 @@ | |||
# Specify analysis options. | |||
# | |||
# Until there are meta linter rules, each desired lint must be explicitly enabled. | |||
# See: https://github.com/dart-lang/linter/issues/288 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the link is not relevant, but isn't it still true that we have to manually enable every lint?
It'd be great if we had a test that checked that when Dart is rolled, the lints in this file (including those commented out) exactly match the list of lints in the version of Dart...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, filed #101596 for that.
test-exempt: is a test |
The (deprecated)
implicit-casts: false
option was disabled in #100862 - unfortunately without enabling its replacementstrict-casts: true
.See also https://dart.googlesource.com/sdk.git/+/6a54fdd46e2df14c9a7b4fd9d6b2d6e181ca0b7a.
This PR also updates some minor comments in the analysis_options file.