-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Adds macOS project files to layers example #102539
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fa14e1e
to
ca4dfdc
Compare
examples/layers/macos/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
Outdated
Show resolved
Hide resolved
9837228
to
e18528b
Compare
test-exempt: configuration change |
@jmagman looks like some examples have |
e18528b
to
c5a9635
Compare
This PR slipped my mine for a couple weeks. Icons removed and .metadata added. @jmagman PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c5a9635
to
6bc24a1
Compare
Adds macOS support to the layers examples collection. Issue: flutter#84306
6bc24a1
to
e1f54d9
Compare
Adds macOS support to the layers examples collection.
Issue: #84306
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.