-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on curly_braces_in_flow_control_structures
for developer-facing code
#105113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -98,7 +98,7 @@ linter: | |||
# - conditional_uri_does_not_exist # not yet tested | |||
# - constant_identifier_names # needs an opt-out https://github.com/dart-lang/linter/issues/204 | |||
- control_flow_in_finally | |||
# - curly_braces_in_flow_control_structures # not required by flutter style | |||
# - curly_braces_in_flow_control_structures # not required by flutter style, but developer-facing code should have this on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just unify this and turn it on right here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for the issue at hand, so I'll let someone else tackle that. :)
examples/api
packages
Part of #104498
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.