[Windows] add generated plugins ignores #109973
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
|
Any concerns @cbracken? It looks like you may need to rebase off the lastest |
Rebased and CI passed. |
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
|
test-exempt: configuration change |
|
Thanks for the contribution! 🎉 |
Add generated plugins ignores for windows platform.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].