[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 16 context menu #115805

Merged
merged 11 commits into from
Nov 29, 2022
Merged

iOS 16 context menu #115805

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ebbd84
Basic appearance of the iOS 16 light mode context menu
justinmc Nov 22, 2022
6322a11
Properly change light/dark mode on demand
justinmc Nov 22, 2022
e5bcfc5
Adjust shadow to be less subtle and hopefully match native better
justinmc Nov 22, 2022
ddf6fef
Clean up code
justinmc Nov 22, 2022
99cf940
Test
justinmc Nov 22, 2022
234314f
Fix test
justinmc Nov 22, 2022
009b3af
Cupertino text selection toolbar not used on web
justinmc Nov 26, 2022
3eea5a2
Merge branch 'master' into ios-16-context-menu
justinmc Nov 28, 2022
67e910f
Use CupertinoDynamicColor
justinmc Nov 28, 2022
42051d9
Code review, more CupertinoDynamicColor
justinmc Nov 28, 2022
230a7f6
Fix test with hardcoded colors
justinmc Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test with hardcoded colors
  • Loading branch information
@justinmc
justinmc committed Nov 29, 2022
commit 230a7f63fa5a40de1be5aef7b6e4d939606bbb52
8 changes: 6 additions & 2 deletions packages/flutter/test/cupertino/text_field_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,7 +1523,11 @@ void main() {
await tester.pump(const Duration(milliseconds: 200));

Text text = tester.widget<Text>(find.text('Paste'));
expect(text.style!.color, CupertinoColors.black);
const CupertinoDynamicColor toolbarTextColor = CupertinoDynamicColor.withBrightness(
color: CupertinoColors.black,
darkColor: CupertinoColors.white,
);
expect(text.style!.color, toolbarTextColor);
expect(text.style!.fontSize, 14);
expect(text.style!.letterSpacing, -0.15);
expect(text.style!.fontWeight, FontWeight.w400);
Expand Down Expand Up @@ -1555,7 +1559,7 @@ void main() {

text = tester.widget<Text>(find.text('Paste'));
// The toolbar buttons' text are still the same style.
expect(text.style!.color, CupertinoColors.black);
expect(text.style!.color, toolbarTextColor);
expect(text.style!.fontSize, 14);
expect(text.style!.letterSpacing, -0.15);
expect(text.style!.fontWeight, FontWeight.w400);
Expand Down