Remove unnecessary null checks in flutter/painting
#118925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This was referenced Jan 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 21, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 21, 2023
* ec6ff90ab Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893) * 492d57262 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894) * f291eb349 Remove unnecessary null checks in integration_test (flutter/flutter#118861) * ab3c82244 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842) * bf72f5ebf 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899) * a07e8a6ac [reland] Support wireless debugging (flutter/flutter#118895) * 3c769effa Cupertino navbar ellipsis fix (flutter/flutter#118841) * d1be731c6 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909) * c0ad6add2 Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706) * 83720015a Remove unnecessary null checks in flutter_test (flutter/flutter#118865) * 288a7733e Remove unnecessary null checks in flutter_driver (flutter/flutter#118864) * bb73121cb Remove unnecessary null checks in flutter/test (flutter/flutter#118905) * 15bc4e466 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693) * 1cdaf9e33 e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913) * 49e025d8a Update android defines test to use emulator (flutter/flutter#118808) * bae4c1d24 Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928) * 9837eb6fc Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923) * 25843bdb5 Remove macOS impeller benchmarks (flutter/flutter#118917) * 70cecf6c9 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844) * c757df3bf Remove unnecessary null checks in dev/bots (flutter/flutter#118846) * 5d74b5cbf Remove unnecessary null checks in flutter/painting (flutter/flutter#118925) * 7272c809e Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922) * 2baea2f62 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933) * 8d60a8c0b Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938) * 5ccdb8107 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942) * b1f4070d5 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 22, 2023
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Jan 22, 2023
* 3c769ef Cupertino navbar ellipsis fix (flutter/flutter#118841) * d1be731 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909) * c0ad6ad Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706) * 8372001 Remove unnecessary null checks in flutter_test (flutter/flutter#118865) * 288a773 Remove unnecessary null checks in flutter_driver (flutter/flutter#118864) * bb73121 Remove unnecessary null checks in flutter/test (flutter/flutter#118905) * 15bc4e4 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693) * 1cdaf9e e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913) * 49e025d Update android defines test to use emulator (flutter/flutter#118808) * bae4c1d Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928) * 9837eb6 Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923) * 25843bd Remove macOS impeller benchmarks (flutter/flutter#118917) * 70cecf6 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844) * c757df3 Remove unnecessary null checks in dev/bots (flutter/flutter#118846) * 5d74b5c Remove unnecessary null checks in flutter/painting (flutter/flutter#118925) * 7272c80 Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922) * 2baea2f 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933) * 8d60a8c Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938) * 5ccdb81 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942) * b1f4070 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944) * 8065887 Add transform flip (flutter/flutter#116705) * 68b6e72 406dce64f Roll Fuchsia Mac SDK from ZTKDeVL1HDAwsZdhl... to l7jVM3Urw73TVWfee... (flutter/engine#39050) (flutter/flutter#118964) * cf628ad aa194347a Roll Fuchsia Linux SDK from S6wQW1tLFe-YnReaZ... to l3c_b-vRr-o6ZFX_M... (flutter/engine#39055) (flutter/flutter#118968) * f33e8d3 2a2dfaafb Roll Fuchsia Mac SDK from l7jVM3Urw73TVWfee... to 5TQ9IL4-Yu3KHCR-H... (flutter/engine#39056) (flutter/flutter#118969)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* 3c769ef Cupertino navbar ellipsis fix (flutter/flutter#118841) * d1be731 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909) * c0ad6ad Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706) * 8372001 Remove unnecessary null checks in flutter_test (flutter/flutter#118865) * 288a773 Remove unnecessary null checks in flutter_driver (flutter/flutter#118864) * bb73121 Remove unnecessary null checks in flutter/test (flutter/flutter#118905) * 15bc4e4 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693) * 1cdaf9e e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913) * 49e025d Update android defines test to use emulator (flutter/flutter#118808) * bae4c1d Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928) * 9837eb6 Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923) * 25843bd Remove macOS impeller benchmarks (flutter/flutter#118917) * 70cecf6 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844) * c757df3 Remove unnecessary null checks in dev/bots (flutter/flutter#118846) * 5d74b5c Remove unnecessary null checks in flutter/painting (flutter/flutter#118925) * 7272c80 Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922) * 2baea2f 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933) * 8d60a8c Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938) * 5ccdb81 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942) * b1f4070 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944) * 8065887 Add transform flip (flutter/flutter#116705) * 68b6e72 406dce64f Roll Fuchsia Mac SDK from ZTKDeVL1HDAwsZdhl... to l7jVM3Urw73TVWfee... (flutter/engine#39050) (flutter/flutter#118964) * cf628ad aa194347a Roll Fuchsia Linux SDK from S6wQW1tLFe-YnReaZ... to l3c_b-vRr-o6ZFX_M... (flutter/engine#39055) (flutter/flutter#118968) * f33e8d3 2a2dfaafb Roll Fuchsia Mac SDK from l7jVM3Urw73TVWfee... to 5TQ9IL4-Yu3KHCR-H... (flutter/engine#39056) (flutter/flutter#118969)
Maatteogekko
pushed a commit
to Maatteogekko/packages
that referenced
this pull request
Feb 4, 2023
…r#3078) * ec6ff90ab Roll Flutter Engine from ccccee513fb2 to d84b3dc74c9f (2 revisions) (flutter/flutter#118893) * 492d57262 Cleanup obsolete --compact-async compiler option (flutter/flutter#118894) * f291eb349 Remove unnecessary null checks in integration_test (flutter/flutter#118861) * ab3c82244 Remove unnecessary null checks in dev/devicelab (flutter/flutter#118842) * bf72f5ebf 58eb1061e Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) (flutter/flutter#118899) * a07e8a6ac [reland] Support wireless debugging (flutter/flutter#118895) * 3c769effa Cupertino navbar ellipsis fix (flutter/flutter#118841) * d1be731c6 3fead63ba Roll Dart SDK from ac4c63168ff2 to 03d35455a8d8 (1 revision) (flutter/engine#39036) (flutter/flutter#118909) * c0ad6add2 Marks Mac plugin_test_macos to be unflaky (flutter/flutter#118706) * 83720015a Remove unnecessary null checks in flutter_test (flutter/flutter#118865) * 288a7733e Remove unnecessary null checks in flutter_driver (flutter/flutter#118864) * bb73121cb Remove unnecessary null checks in flutter/test (flutter/flutter#118905) * 15bc4e466 Marks Mac_android microbenchmarks to be flaky (flutter/flutter#118693) * 1cdaf9e33 e2c2e5009 [impeller] correct input order in ColorFilterContents::MakeBlend (flutter/engine#39038) (flutter/flutter#118913) * 49e025d8a Update android defines test to use emulator (flutter/flutter#118808) * bae4c1d24 Revert "Update android defines test to use emulator (#118808)" (flutter/flutter#118928) * 9837eb6fc Remove unnecessary null checks in flutter/rendering (flutter/flutter#118923) * 25843bdb5 Remove macOS impeller benchmarks (flutter/flutter#118917) * 70cecf6c9 Remove unnecessary null checks in dev/*_tests (flutter/flutter#118844) * c757df3bf Remove unnecessary null checks in dev/bots (flutter/flutter#118846) * 5d74b5cbf Remove unnecessary null checks in flutter/painting (flutter/flutter#118925) * 7272c809e Remove unnecessary null checks in `flutter/{animation,semantics,scheduler}` (flutter/flutter#118922) * 2baea2f62 7b68d71b8 Roll Dart SDK from 03d35455a8d8 to 807077cc5d1b (1 revision) (flutter/engine#39042) (flutter/flutter#118933) * 8d60a8c0b Roll Flutter Engine from 7b68d71b8d03 to 3a444b36657c (3 revisions) (flutter/flutter#118938) * 5ccdb8107 bb4e8dfe2 Roll Fuchsia Linux SDK from rPo4_TYHCtkoOfRup... to S6wQW1tLFe-YnReaZ... (flutter/engine#39048) (flutter/flutter#118942) * b1f4070d5 ef7b1856a Roll Dart SDK from 8c2eb20b5376 to 548678dd684c (1 revision) (flutter/engine#39049) (flutter/flutter#118944)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118837.
Dart 3 drops support for non-null safe code, so we can finally turn on the unnecessary_null_comparison lint and remove the unnecessary checks it flags.