[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add M3 support for iconbuttons in error state in TextFields #119925

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Add M3 support for iconbuttons in error state in TextFields #119925

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c086f32
add m3 iconbutton override
esouthren Feb 3, 2023
c75f634
changes
esouthren Feb 3, 2023
a6de1c7
spring cleaning
esouthren Feb 3, 2023
d0dc17f
whitespace fix
esouthren Feb 3, 2023
63b4644
sneaky whitespaces
esouthren Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spring cleaning
  • Loading branch information
@esouthren
esouthren committed Feb 3, 2023
commit a6de1c76a7262a26d33071807e8287ebc7de8bcd
3 changes: 1 addition & 2 deletions packages/flutter/lib/src/material/input_decorator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ import 'package:flutter/widgets.dart';
import 'color_scheme.dart';
import 'colors.dart';
import 'constants.dart';
import 'input_border.dart';
import 'input_decorator.dart';
import 'icon_button.dart';
import 'icon_button_theme.dart';
import 'input_border.dart';
import 'material.dart';
import 'material_state.dart';
import 'text_theme.dart';
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter/test/material/input_decorator_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1744,7 +1744,7 @@ void main() {
useMaterial3: true,
iconButtonTheme: const IconButtonThemeData(
style: ButtonStyle(
foregroundColor: MaterialStatePropertyAll(Colors.blue),
foregroundColor: MaterialStatePropertyAll<Color>(Colors.blue),
),
),
);
Expand All @@ -1754,7 +1754,7 @@ void main() {
home: Material(
child: TextField(
decoration: InputDecoration(
suffixIcon: IconButton(icon: Icon(Icons.close), onPressed: () {}),
suffixIcon: IconButton(icon: const Icon(Icons.close), onPressed: () {}),
errorText: 'error state',
filled: true,
),
Expand Down