Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220

CaseyHillers · 2023-02-22T15:49:58Z

This is breaking internal tests as some goldens are showing an asset can no longer be found.

… manifest for image resolution (#118782)" This reverts commit e3db048.

XilaiZhang

Thank you Casey!
That was a great catch!

andrewkolos · 2023-02-22T18:46:57Z

This is breaking internal tests as some goldens are showing an asset can no longer be found.

#118782 made Flutter throw an error earlier when trying to resolve an asset that wasn't included using the assets attribute in pubspec.yaml (see Specifying assets). Some internal tests didn't include assets via the corresponding internal build rule attribute, but they would still work because the files were bundled via other means (and thus present on the filesystem at runtime).

andrewkolos

LGTM

…r-image-resolution

auto-submit · 2023-02-22T18:53:51Z

auto label is removed for flutter/flutter, pr: 121220, due to - The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite tool_tests-commands-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r-image-resolution

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

Revert "Speed up first asset load by using the binary-formatted asset…

59a4079

… manifest for image resolution (#118782)" This reverts commit e3db048.

CaseyHillers requested review from andrewkolos and XilaiZhang February 22, 2023 15:49

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Feb 22, 2023

XilaiZhang approved these changes Feb 22, 2023

View reviewed changes

andrewkolos approved these changes Feb 22, 2023

View reviewed changes

Merge branch 'master' into revert-118782-use-binary-asset-manifest-fo…

6bcba09

…r-image-resolution

CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023

XilaiZhang mentioned this pull request Feb 22, 2023

[roll + cherry pick] Revert "Speed up first asset load by using the binary-formatted asset… #121268

Merged

Merge branch 'master' into revert-118782-use-binary-asset-manifest-fo…

a614d56

…r-image-resolution

XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2023

auto-submit bot merged commit 8f7ccd4 into master Feb 23, 2023

auto-submit bot deleted the revert-118782-use-binary-asset-manifest-for-image-resolution branch February 23, 2023 00:13

engine-flutter-autoroll mentioned this pull request Feb 23, 2023

Roll Flutter from 7175de4fe686 to 19b2aa14c08f (42 revisions) flutter/packages#3276

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

a0eb6b6

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 23, 2023

Roll Flutter from 7175de4fe686 to af347d667735 (43 revisions) flutter/packages#3280

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

db729eb

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 23, 2023

Roll Flutter from 7175de4fe686 to c722ce419a73 (46 revisions) flutter/packages#3283

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

deeb3d3

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 24, 2023

Roll Flutter from 7175de4fe686 to 219ff645743f (62 revisions) flutter/packages#3289

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

2c74408

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 24, 2023

Roll Flutter from 7175de4fe686 to dfe7f841b3cc (63 revisions) flutter/packages#3290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

d206b1b

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 24, 2023

Roll Flutter from 7175de4fe686 to 5d99748c7a34 (64 revisions) flutter/packages#3291

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

dc84ec5

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 24, 2023

Roll Flutter from 7175de4fe686 to 9e6214f873fa (65 revisions) flutter/packages#3292

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

1b24aa8

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll mentioned this pull request Feb 24, 2023

Roll Flutter from 7175de4fe686 to cb67ecd97d1f (66 revisions) flutter/packages#3294

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

7dd095e

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

2b6090e

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

4c43973

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

81578fb

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

8b00466

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

06bfdc6

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

e93bcbb

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

072608b

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

4e593d3

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

9bdde6e

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

50b912c

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

37538d1

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

0f049a6

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

3759d24

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

d535b21

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

8f7ccd4c4 Revert "Speed up first asset load by using the binary-forma…

574bfd3

…tted asset manifest for image resolution (#118782)" (flutter/flutter#121220)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220

Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220

Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220

Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment