-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup flutter config output #122384
Cleanup flutter config output #122384
Conversation
SGTM |
@christopherfujino I fixed the test, can you PTAL? |
@mit-mit you may want to update the branch with the latest changes, there was a test ( |
@eliasyishak done! |
auto label is removed for flutter/flutter, pr: 122384, due to This PR has not met approval requirements for merging. You have project association MEMBER and need 1 more review(s) in order to merge this PR.
|
oh, I thought this label was "auto merge once approved" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you should be able to add back your auto submit label now
I'd like to propose that we cleanup the
flutter config
help output, by only printing channel notes for options that are limited to a subset of the possible branches.Current output
Update after PR
This is a draft PR as I havn't updated tests yet (i'll do that if there is agreement that this change is good).
List which issues are fixed by this PR. You must list at least one issue.
No issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
TBD
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.