Add validator that alwasys returns false and test, plus todo in integ…

…ration test
flutter · reidbaker · Apr 5, 2023 · Mar 23, 2023 · Mar 23, 2023 · Mar 24, 2023
commit 7b4f418b22998e37bac4ef8e9db1f04adec0de1d
diff --git a/packages/flutter_tools/lib/src/android/gradle_utils.dart b/packages/flutter_tools/lib/src/android/gradle_utils.dart
@@ -168,9 +168,9 @@ Future<String?> getGradleVersion(
         distributionUrlRegex.firstMatch(wrapperFileContent);
     if (distributionUrl != null) {
       try {
-        final String androidPluginVersion =
+        final String gradleVersion =
             distributionUrl.group(0)!.split('-')[1];
-        return androidPluginVersion;
+        return gradleVersion;
         // ignore: empty_catches
       } on TypeError {}
     } else {
@@ -182,7 +182,7 @@ Future<String?> getGradleVersion(
      logger.printTrace(
           '$propertiesFile does not exist falling back to system gradle');
   }
-  // System installed Gradle version. 
+  // System installed Gradle version.
   if (processManager.canRun('gradle')) {
     final String gradleVersionVerbose =
         (await processManager.run(<String>['gradle', r'--version'])).stdout

diff --git a/packages/flutter_tools/lib/src/project.dart b/packages/flutter_tools/lib/src/project.dart
@@ -533,13 +533,15 @@ class AndroidProject extends FlutterProjectPlatform {
     return parent.isModule || _editableHostAppDirectory.existsSync();
   }
 
-  String get gradleVersion {
-    if (!isUsingGradle) {
-      // TODO fail in some clever way
-      print('Not using gradle');
-      return '';
-    }
-    return ''; // TODO call gradleUtils. 
+  Future<bool> hasValidJavaGradleAgpVersions() async {
+    String javaVersion = '11';
+    String gradleVersion = '6.7.1';
+    String agpVersion = '4.2.0';
+
+    String? localGradleVersion = await gradle.getGradleVersion(
+        hostAppGradleRoot, globals.logger, globals.processManager);
+
+    return false;
   }
 
   bool get isUsingGradle {

diff --git a/packages/flutter_tools/lib/src/project_validator.dart b/packages/flutter_tools/lib/src/project_validator.dart
@@ -23,6 +23,7 @@ abstract class ProjectValidator {
   String get title;
   bool get machineOutput => false;
   bool supportsProject(FlutterProject project);
+
   /// Can return more than one result in case a file/command have a lot of info to share to the user
   Future<List<ProjectValidatorResult>> start(FlutterProject project);
 }
@@ -57,6 +58,7 @@ class VariableDumpMachineProjectValidator extends MachineProjectValidator {
     return value;
   }
 
+  //DEAD CODE?
   @override
   Future<List<ProjectValidatorResult>> start(FlutterProject project) async {
     final List<ProjectValidatorResult> result = <ProjectValidatorResult>[];
@@ -112,6 +114,16 @@ class VariableDumpMachineProjectValidator extends MachineProjectValidator {
       value: _toJsonValue(project.android.isKotlin),
       status: StatusProjectValidator.info,
     ));
+    // TODO REMOVE.
+    final bool validJavaGradleAgpVersions =
+        await project.android.hasValidJavaGradleAgpVersions();
+    result.add(ProjectValidatorResult(
+      name: 'Java/Gradle/Android Gradle Plugin',
+      value: _toJsonValue(validJavaGradleAgpVersions),
+      status: validJavaGradleAgpVersions
+          ? StatusProjectValidator.success
+          : StatusProjectValidator.error,
+    ));
     result.add(ProjectValidatorResult(
       name: 'FlutterProject.ios.isSwift',
       value: _toJsonValue(project.ios.isSwift),
@@ -136,7 +148,8 @@ class VariableDumpMachineProjectValidator extends MachineProjectValidator {
     ));
 
     // FlutterVersion
-    final FlutterVersion version = FlutterVersion(workingDirectory: project.directory.absolute.path);
+    final FlutterVersion version =
+        FlutterVersion(workingDirectory: project.directory.absolute.path);
     result.add(ProjectValidatorResult(
       name: 'FlutterVersion.frameworkRevision',
       value: _toJsonValue(version.frameworkRevision),
@@ -202,28 +215,40 @@ class VariableDumpMachineProjectValidator extends MachineProjectValidator {
 /// Validator run for all platforms that extract information from the pubspec.yaml.
 ///
 /// Specific info from different platforms should be written in their own ProjectValidator.
-class GeneralInfoProjectValidator extends ProjectValidator{
+class GeneralInfoProjectValidator extends ProjectValidator {
   @override
   Future<List<ProjectValidatorResult>> start(FlutterProject project) async {
     final FlutterManifest flutterManifest = project.manifest;
     final List<ProjectValidatorResult> result = <ProjectValidatorResult>[];
-    final ProjectValidatorResult appNameValidatorResult = _getAppNameResult(flutterManifest);
+    final ProjectValidatorResult appNameValidatorResult =
+        _getAppNameResult(flutterManifest);
     result.add(appNameValidatorResult);
     final String supportedPlatforms = _getSupportedPlatforms(project);
     if (supportedPlatforms.isEmpty) {
       return result;
     }
-    final ProjectValidatorResult supportedPlatformsResult = ProjectValidatorResult(
-        name: 'Supported Platforms',
-        value: supportedPlatforms,
-        status: StatusProjectValidator.success
-    );
-    final ProjectValidatorResult isFlutterPackage = _isFlutterPackageValidatorResult(flutterManifest);
-    result.addAll(<ProjectValidatorResult>[supportedPlatformsResult, isFlutterPackage]);
+    final ProjectValidatorResult supportedPlatformsResult =
+        ProjectValidatorResult(
+            name: 'Supported Platforms',
+            value: supportedPlatforms,
+            status: StatusProjectValidator.success);
+    final ProjectValidatorResult isFlutterPackage =
+        _isFlutterPackageValidatorResult(flutterManifest);
+    result.addAll(
+        <ProjectValidatorResult>[supportedPlatformsResult, isFlutterPackage]);
     if (flutterManifest.flutterDescriptor.isNotEmpty) {
       result.add(_materialDesignResult(flutterManifest));
       result.add(_pluginValidatorResult(flutterManifest));
     }
+    final bool validJavaGradleAgpVersions =
+        await project.android.hasValidJavaGradleAgpVersions();
+    result.add(ProjectValidatorResult(
+      name: 'FlutterProject.android.compatibleJavaGradleAgp',
+      value: validJavaGradleAgpVersions ? 'Java/Gradle/AGP appear compatible' : 'Incompatible Java/Gradle/AGP versions',
+      status: validJavaGradleAgpVersions
+          ? StatusProjectValidator.success
+          : StatusProjectValidator.error,
+    ));
     return result;
   }
 
@@ -234,17 +259,14 @@ class GeneralInfoProjectValidator extends ProjectValidator{
       return const ProjectValidatorResult(
           name: name,
           value: 'name not found',
-          status: StatusProjectValidator.error
-      );
+          status: StatusProjectValidator.error);
     }
     return ProjectValidatorResult(
-        name: name,
-        value: appName,
-        status: StatusProjectValidator.success
-    );
+        name: name, value: appName, status: StatusProjectValidator.success);
   }
 
-  ProjectValidatorResult _isFlutterPackageValidatorResult(FlutterManifest flutterManifest) {
+  ProjectValidatorResult _isFlutterPackageValidatorResult(
+      FlutterManifest flutterManifest) {
     final String value;
     final StatusProjectValidator status;
     if (flutterManifest.flutterDescriptor.isNotEmpty) {
@@ -256,30 +278,30 @@ class GeneralInfoProjectValidator extends ProjectValidator{
     }
 
     return ProjectValidatorResult(
-        name: 'Is Flutter Package',
-        value: value,
-        status: status
-    );
+        name: 'Is Flutter Package', value: value, status: status);
   }
 
-  ProjectValidatorResult _materialDesignResult(FlutterManifest flutterManifest) {
+  ProjectValidatorResult _materialDesignResult(
+      FlutterManifest flutterManifest) {
     return ProjectValidatorResult(
-      name: 'Uses Material Design',
-      value: flutterManifest.usesMaterialDesign? 'yes' : 'no',
-      status: StatusProjectValidator.success
-    );
+        name: 'Uses Material Design',
+        value: flutterManifest.usesMaterialDesign ? 'yes' : 'no',
+        status: StatusProjectValidator.success);
   }
 
   String _getSupportedPlatforms(FlutterProject project) {
-    return project.getSupportedPlatforms().map((SupportedPlatform platform) => platform.name).join(', ');
+    return project
+        .getSupportedPlatforms()
+        .map((SupportedPlatform platform) => platform.name)
+        .join(', ');
   }
 
-  ProjectValidatorResult _pluginValidatorResult(FlutterManifest flutterManifest) {
+  ProjectValidatorResult _pluginValidatorResult(
+      FlutterManifest flutterManifest) {
     return ProjectValidatorResult(
-      name: 'Is Plugin',
-      value: flutterManifest.isPlugin? 'yes' : 'no',
-      status: StatusProjectValidator.success
-    );
+        name: 'Is Plugin',
+        value: flutterManifest.isPlugin ? 'yes' : 'no',
+        status: StatusProjectValidator.success);
   }
 
   @override
@@ -299,26 +321,28 @@ class PubDependenciesProjectValidator extends ProjectValidator {
   @override
   Future<List<ProjectValidatorResult>> start(FlutterProject project) async {
     const String name = 'Dart dependencies';
-    final ProcessResult processResult = await _processManager.run(<String>['dart', 'pub', 'deps', '--json']);
+    final ProcessResult processResult =
+        await _processManager.run(<String>['dart', 'pub', 'deps', '--json']);
     if (processResult.stdout is! String) {
       return <ProjectValidatorResult>[
-        _createProjectValidatorError(name, 'Command dart pub deps --json failed')
+        _createProjectValidatorError(
+            name, 'Command dart pub deps --json failed')
       ];
     }
 
     final LinkedHashMap<String, dynamic> jsonResult;
     final List<ProjectValidatorResult> result = <ProjectValidatorResult>[];
     try {
-      jsonResult = json.decode(
-        processResult.stdout.toString()
-      ) as LinkedHashMap<String, dynamic>;
-    } on FormatException{
-      result.add(_createProjectValidatorError(name, processResult.stderr.toString()));
+      jsonResult = json.decode(processResult.stdout.toString())
+          as LinkedHashMap<String, dynamic>;
+    } on FormatException {
+      result.add(
+          _createProjectValidatorError(name, processResult.stderr.toString()));
       return result;
     }
 
     final DartPubJson dartPubJson = DartPubJson(jsonResult);
-    final List <String> dependencies = <String>[];
+    final List<String> dependencies = <String>[];
 
     // Information retrieved from the pubspec.lock file if a dependency comes from
     // the hosted url https://pub.dartlang.org we ignore it or if the package
@@ -339,13 +363,11 @@ class PubDependenciesProjectValidator extends ProjectValidator {
       value = 'All pub dependencies are hosted on https://pub.dartlang.org';
     }
 
-    result.add(
-       ProjectValidatorResult(
-        name: name,
-        value: value,
-        status: StatusProjectValidator.info,
-      )
-    );
+    result.add(ProjectValidatorResult(
+      name: name,
+      value: value,
+      status: StatusProjectValidator.info,
+    ));
 
     return result;
   }
@@ -358,7 +380,9 @@ class PubDependenciesProjectValidator extends ProjectValidator {
   @override
   String get title => 'Pub dependencies';
 
-  ProjectValidatorResult _createProjectValidatorError(String name, String value) {
-    return ProjectValidatorResult(name: name, value: value, status: StatusProjectValidator.error);
+  ProjectValidatorResult _createProjectValidatorError(
+      String name, String value) {
+    return ProjectValidatorResult(
+        name: name, value: value, status: StatusProjectValidator.error);
   }
 }
diff --git a/packages/flutter_tools/test/general.shard/project_test.dart b/packages/flutter_tools/test/general.shard/project_test.dart
@@ -401,6 +401,13 @@ void main() {
       });
     });
 
+    group('compatibality', () {
+      _testInMemory('always returns false', () async {
+        final FlutterProject project = await someProject();
+        expect(await project.android.hasValidJavaGradleAgpVersions(), isFalse);
+      });
+    });
+
     group('language', () {
       late XcodeProjectInterpreter xcodeProjectInterpreter;
       late MemoryFileSystem fs;

diff --git a/packages/flutter_tools/test/integration.shard/analyze_suggestions_integration_test.dart b/packages/flutter_tools/test/integration.shard/analyze_suggestions_integration_test.dart
@@ -27,6 +27,7 @@ void main() {
       fileSystem = globals.localFileSystem;
     });
 
+    // TODO update for java/gradle/agp content.
     testUsingContext('General Info Project Validator', () async {
       final BufferLogger loggerTest = BufferLogger.test();
       final AnalyzeCommand command = AnalyzeCommand(