[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual overflow for SliverMainAxisGroup #132989

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

Piinks
Copy link
Contributor
@Piinks Piinks commented Aug 21, 2023

Fixes #132788

The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 21, 2023
@Piinks Piinks requested a review from TahaTesser August 21, 2023 20:31
Copy link
Member
@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@auto-submit auto-submit bot merged commit a5b06f1 into flutter:master Aug 22, 2023
73 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 22, 2023
flutter/flutter@5e6d88d...54c98d7

2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) (flutter/flutter#133035)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) (flutter/flutter#133031)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) (flutter/flutter#133030)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) (flutter/flutter#133026)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) (flutter/flutter#133020)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) (flutter/flutter#133018)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) (flutter/flutter#133014)
2023-08-22 katelovett@google.com Fix visual overflow for SliverMainAxisGroup (flutter/flutter#132989)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) (flutter/flutter#133010)
2023-08-22 matanlurey@users.noreply.github.com Always require `--local-engine-host` if `--local-engine` (flutter/flutter#133003)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) (flutter/flutter#133005)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) (flutter/flutter#133000)
2023-08-21 angelosilvestre.ccp@gmail.com Add deleteBackwardByDecomposingPreviousCharacter mapping for tests (flutter/flutter#132919)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) (flutter/flutter#132996)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) (flutter/flutter#132992)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) (flutter/flutter#132986)
2023-08-21 tessertaha@gmail.com  Update `ExpansionPanel` example for the updated `expansionCallback` callback (flutter/flutter#132837)
2023-08-21 34871572+gmackall@users.noreply.github.com Change gradle lockfile generation script to use --config-only flag (flutter/flutter#132967)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) (flutter/flutter#132973)
2023-08-21 jmccandless@google.com Docs on iOS's directional quote characters (flutter/flutter#132869)
2023-08-21 reidbaker@google.com Bump memory usage for flutter gallery (flutter/flutter#132968)
2023-08-21 5236035+fzyzcjy@users.noreply.github.com When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK (flutter/flutter#127456)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) (flutter/flutter#132962)
2023-08-21 engine-flutter-autoroll@skia.org Roll Packages from 4c16f3e to e26f3b9 (5 revisions) (flutter/flutter#132960)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Piinks added a commit to Piinks/flutter that referenced this pull request Aug 22, 2023
Fixes flutter#132788

The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.
@yk3372
Copy link
Contributor
yk3372 commented Aug 26, 2023

hope this change merge to stable as soon as possible

XilaiZhang pushed a commit that referenced this pull request Sep 5, 2023
Cherry picks #132989 which fixes
#132788

Fixes #133058

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slivers not being clipped in CustomScrollView with SliverMainAxisGroup on Flutter 3.13
3 participants