-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to TableCell docs #138258
Merged
Merged
Add to TableCell docs #138258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -397,6 +397,9 @@ class _TableElement extends RenderObjectElement { | |||
/// the [TableCell] widget to its enclosing [Table] must contain only | |||
/// [TableRow]s, [StatelessWidget]s, or [StatefulWidget]s (not | |||
/// other kinds of widgets, like [RenderObjectWidget]s). | |||
/// | |||
/// To create an empty [TableCell], provide a [Container] or [SizedBox.shrink] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While both work, SizedBox.shrink will be every so slightly more efficient. I would only mention that one and remove "Container".
Piinks
commented
Nov 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 16, 2023
Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions) flutter/flutter@e8c2bb1...53a57ad 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (flutter/flutter#138543) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (flutter/flutter#138533) 2023-11-16 leroux_bruno@yahoo.fr [flutter_tools] - Add `queries` section to Android manifest file (flutter/flutter#137207) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (flutter/flutter#138532) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (flutter/flutter#138529) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (flutter/flutter#138515) 2023-11-15 42216813+eliasyishak@users.noreply.github.com Catch error for missing directory in `FontConfigManager` (flutter/flutter#138496) 2023-11-15 bernaferrari2@gmail.com Make `UnderlineInputBorder` consistent (flutter/flutter#124153) 2023-11-15 gspencergoog@users.noreply.github.com Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (flutter/flutter#136854) 2023-11-15 58529443+srujzs@users.noreply.github.com Pin package:web 0.4.0 (flutter/flutter#138428) 2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland VelocityTracker update (#132291)" (flutter/flutter#138512) 2023-11-15 yjbanov@google.com [web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (flutter/flutter#138498) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (flutter/flutter#138502) 2023-11-15 katelovett@google.com Reland VelocityTracker update (#132291) (flutter/flutter#137381) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (flutter/flutter#138499) 2023-11-15 katelovett@google.com Fix 2D tap to stop scrolling (flutter/flutter#138442) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (flutter/flutter#138494) 2023-11-15 41873024+droidbg@users.noreply.github.com SemanticOwner should dispatch creation and disposal events (flutter/flutter#138388) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (flutter/flutter#138489) 2023-11-15 engine-flutter-autoroll@skia.org Roll Packages from 428ba3e to 0cd2378 (1 revision) (flutter/flutter#138482) 2023-11-15 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (flutter/flutter#138472) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (flutter/flutter#138468) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (flutter/flutter#138463) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (flutter/flutter#138462) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (flutter/flutter#138459) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (flutter/flutter#138457) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (flutter/flutter#138456) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (flutter/flutter#138452) 2023-11-15 xubaolin@oppo.com Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136871) 2023-11-14 katelovett@google.com Add to TableCell docs (flutter/flutter#138258) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (flutter/flutter#138441) 2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.1 to 5.0.0 (flutter/flutter#138437) 2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.5 to 2.22.6 (flutter/flutter#138438) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (flutter/flutter#138429) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (flutter/flutter#138425) 2023-11-14 42216813+eliasyishak@users.noreply.github.com Unified analytics migration for `CodeSizeAnalysis` (flutter/flutter#138351) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (flutter/flutter#138421) 2023-11-14 goderbauer@google.com Run all tests in examples/ (flutter/flutter#138374) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (flutter/flutter#138420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. ...
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
…r#5412) Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions) flutter/flutter@e8c2bb1...53a57ad 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (flutter/flutter#138543) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (flutter/flutter#138533) 2023-11-16 leroux_bruno@yahoo.fr [flutter_tools] - Add `queries` section to Android manifest file (flutter/flutter#137207) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (flutter/flutter#138532) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (flutter/flutter#138529) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (flutter/flutter#138515) 2023-11-15 42216813+eliasyishak@users.noreply.github.com Catch error for missing directory in `FontConfigManager` (flutter/flutter#138496) 2023-11-15 bernaferrari2@gmail.com Make `UnderlineInputBorder` consistent (flutter/flutter#124153) 2023-11-15 gspencergoog@users.noreply.github.com Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (flutter/flutter#136854) 2023-11-15 58529443+srujzs@users.noreply.github.com Pin package:web 0.4.0 (flutter/flutter#138428) 2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland VelocityTracker update (#132291)" (flutter/flutter#138512) 2023-11-15 yjbanov@google.com [web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (flutter/flutter#138498) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (flutter/flutter#138502) 2023-11-15 katelovett@google.com Reland VelocityTracker update (#132291) (flutter/flutter#137381) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (flutter/flutter#138499) 2023-11-15 katelovett@google.com Fix 2D tap to stop scrolling (flutter/flutter#138442) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (flutter/flutter#138494) 2023-11-15 41873024+droidbg@users.noreply.github.com SemanticOwner should dispatch creation and disposal events (flutter/flutter#138388) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (flutter/flutter#138489) 2023-11-15 engine-flutter-autoroll@skia.org Roll Packages from 428ba3e to 0cd2378 (1 revision) (flutter/flutter#138482) 2023-11-15 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (flutter/flutter#138472) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (flutter/flutter#138468) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (flutter/flutter#138463) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (flutter/flutter#138462) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (flutter/flutter#138459) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (flutter/flutter#138457) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (flutter/flutter#138456) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (flutter/flutter#138452) 2023-11-15 xubaolin@oppo.com Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136871) 2023-11-14 katelovett@google.com Add to TableCell docs (flutter/flutter#138258) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (flutter/flutter#138441) 2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.1 to 5.0.0 (flutter/flutter#138437) 2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.5 to 2.22.6 (flutter/flutter#138438) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (flutter/flutter#138429) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (flutter/flutter#138425) 2023-11-14 42216813+eliasyishak@users.noreply.github.com Unified analytics migration for `CodeSizeAnalysis` (flutter/flutter#138351) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (flutter/flutter#138421) 2023-11-14 goderbauer@google.com Run all tests in examples/ (flutter/flutter#138374) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (flutter/flutter#138420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…r#5412) Roll Flutter from e8c2bb135659 to 53a57adcf136 (39 revisions) flutter/flutter@e8c2bb1...53a57ad 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8ab189b77b8d to 2e9f0df868b3 (1 revision) (flutter/flutter#138543) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 622fa0614412 to 8ab189b77b8d (1 revision) (flutter/flutter#138533) 2023-11-16 leroux_bruno@yahoo.fr [flutter_tools] - Add `queries` section to Android manifest file (flutter/flutter#137207) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aff9c134b8f to 622fa0614412 (1 revision) (flutter/flutter#138532) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cfcdebe8623 to 8aff9c134b8f (18 revisions) (flutter/flutter#138529) 2023-11-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30327eae0802 to 3cfcdebe8623 (1 revision) (flutter/flutter#138515) 2023-11-15 42216813+eliasyishak@users.noreply.github.com Catch error for missing directory in `FontConfigManager` (flutter/flutter#138496) 2023-11-15 bernaferrari2@gmail.com Make `UnderlineInputBorder` consistent (flutter/flutter#124153) 2023-11-15 gspencergoog@users.noreply.github.com Prepare `ShortcutActivator` and `ShortcutManager` to migrate to `KeyEvent` from `RawKeyEvent`. (flutter/flutter#136854) 2023-11-15 58529443+srujzs@users.noreply.github.com Pin package:web 0.4.0 (flutter/flutter#138428) 2023-11-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland VelocityTracker update (#132291)" (flutter/flutter#138512) 2023-11-15 yjbanov@google.com [web] skip flaky overflow_clipbehavior_none.cupertino.0.png golden check (flutter/flutter#138498) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c2b8d520b3d to 30327eae0802 (2 revisions) (flutter/flutter#138502) 2023-11-15 katelovett@google.com Reland VelocityTracker update (#132291) (flutter/flutter#137381) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from f58dac64ad1a to 7c2b8d520b3d (1 revision) (flutter/flutter#138499) 2023-11-15 katelovett@google.com Fix 2D tap to stop scrolling (flutter/flutter#138442) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d22d063ac9f6 to f58dac64ad1a (2 revisions) (flutter/flutter#138494) 2023-11-15 41873024+droidbg@users.noreply.github.com SemanticOwner should dispatch creation and disposal events (flutter/flutter#138388) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from ecaf9442034d to d22d063ac9f6 (5 revisions) (flutter/flutter#138489) 2023-11-15 engine-flutter-autoroll@skia.org Roll Packages from 428ba3e to 0cd2378 (1 revision) (flutter/flutter#138482) 2023-11-15 fluttergithubbot@gmail.com Marks Mac_android hot_mode_dev_cycle__benchmark to be unflaky (flutter/flutter#138472) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7a48a68e6f8 to ecaf9442034d (1 revision) (flutter/flutter#138468) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 976edd5192d1 to a7a48a68e6f8 (3 revisions) (flutter/flutter#138463) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from a7f2267dd1f4 to 976edd5192d1 (1 revision) (flutter/flutter#138462) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc5bbd3b9ebe to a7f2267dd1f4 (1 revision) (flutter/flutter#138459) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from d7ca057b891f to bc5bbd3b9ebe (2 revisions) (flutter/flutter#138457) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1347413470b7 to d7ca057b891f (1 revision) (flutter/flutter#138456) 2023-11-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from c5a067b637f4 to 1347413470b7 (5 revisions) (flutter/flutter#138452) 2023-11-15 xubaolin@oppo.com Reland [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136871) 2023-11-14 katelovett@google.com Add to TableCell docs (flutter/flutter#138258) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from f15b259fe98c to c5a067b637f4 (4 revisions) (flutter/flutter#138441) 2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.1 to 5.0.0 (flutter/flutter#138437) 2023-11-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.5 to 2.22.6 (flutter/flutter#138438) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from eba757803a6f to f15b259fe98c (1 revision) (flutter/flutter#138429) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 603bdd48df8a to eba757803a6f (3 revisions) (flutter/flutter#138425) 2023-11-14 42216813+eliasyishak@users.noreply.github.com Unified analytics migration for `CodeSizeAnalysis` (flutter/flutter#138351) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777dcb99f6e0 to 603bdd48df8a (1 revision) (flutter/flutter#138421) 2023-11-14 goderbauer@google.com Run all tests in examples/ (flutter/flutter#138374) 2023-11-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b3fd80812c3 to 777dcb99f6e0 (2 revisions) (flutter/flutter#138420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
d: api docs
Issues with https://api.flutter.dev/
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42523
Came across a trivial doc issue - now it will be fixed. 😁
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.