Do not ignore pubspec.lock in project templates #24209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also remove it from |
|
Hi @gspencergoog, thanks for review. I just removed |
gspencergoog
approved these changes
Nov 15, 2018
|
Will land once the build is green again. |
|
Thanks for the PR! |
gamebox
pushed a commit
to gamebox/flutter
that referenced
this pull request
Jan 28, 2019
* Remove *.lock from gitignore * Remove pubspec.lock from gitignore
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
* Remove *.lock from gitignore * Remove pubspec.lock from gitignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14768, it has been decided to inlucde
pubspec.lockinto git. But it looks like the project created byflutter create <projectname>still ignore this file. This PR fixes this.