[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added key.properties and *.jks to .gitignore #25413

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

JonathanWilbur
Copy link
Contributor

android/key.properties and key.jks are mentioned here, which store sensitive information that one could inadvertently commit to a repository (which the documentation itself says to avoid).

…mits

`android/key.properties` and `key.jks` are mentioned [here](https://flutter.io/docs/deployment/android), which store sensitive information that one could inadvertently commit to a repository (which the documentation itself says to avoid).
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@JonathanWilbur
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@zoechi zoechi added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 16, 2018
@dnfield
Copy link
Contributor
dnfield commented Jan 11, 2019

Thanks! LGTM

@xster
Copy link
Member
xster commented Jan 15, 2019

Merging since Dan LGTM'ed

@xster xster merged commit c713ef9 into flutter:master Jan 15, 2019
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants