[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial work on coverage generating script for tool #29494

Merged
merged 12 commits into from
Apr 19, 2019

Conversation

jonahwilliams
Copy link
Member
@jonahwilliams jonahwilliams commented Mar 16, 2019

Description

Executes the flutter_tools unit tests and collects the coverage into a single file. This is a temporary helper script, until such a time as we can update the test/build_runner package to do this automagically.

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2019
@jonahwilliams jonahwilliams marked this pull request as ready for review April 18, 2019 16:26
packages/flutter_tools/tool/tool_coverage.dart Outdated Show resolved Hide resolved
packages/flutter_tools/tool/tool_coverage.dart Outdated Show resolved Hide resolved
packages/flutter_tools/tool/tool_coverage.dart Outdated Show resolved Hide resolved
packages/flutter_tools/tool/tool_coverage.dart Outdated Show resolved Hide resolved
packages/flutter_tools/tool/tool_coverage.dart Outdated Show resolved Hide resolved
Copy link
Member
@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ comment

packages/flutter_tools/tool/tool_coverage.dart Outdated Show resolved Hide resolved
@jonahwilliams jonahwilliams merged commit 65f4599 into flutter:master Apr 19, 2019
@jonahwilliams jonahwilliams deleted the generate_coverage branch April 19, 2019 00:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants