update gitignore and xcode changes to macOS project for flutter gallery #48251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
reviewed
Jan 6, 2020
| @@ -93,6 +93,12 @@ unlinked_spec.ds | |||
| **/ios/ServiceDefinitions.json | |||
| **/ios/Runner/GeneratedPluginRegistrant.* | |||
|
|
|||
| # macOS | |||
| **/macos/Flutter/GeneratedPluginRegistrant.swift | |||
There was a problem hiding this comment.
Wonder if ios being in Runner and macos being in Flutter means this is ready for a future cleanup?. Maybe **/macos/**/GeneratedPluginRegistrant.* to make this a bit more refactor-proof.
cc @jmagman
There was a problem hiding this comment.
I'm skeptical of trying to future proof gitignores too much, you might end up accidentally ignoring real code in the future.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent running something in the flutter gallery from creating a dirty files.
Fixes #46743