Start reporting isolate life cycle events #5312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Add IsolateTracker.
- Tell the IsolateTracker what the view's isolate id is.
- Start printing important isolate life cycle events.
| String _viewIsolateId; | ||
| set viewIsolateId(String viewIsolateId) { | ||
| _viewIsolateId = viewIsolateId; | ||
| printStatus('View is now controlled by isolate $_viewIsolateId'); |
|
lgtm, w/ some questions |
|
Looking through old PRs, found this one. Curious of the status? |
|
@eseidelGoogle This is on hold until I lay some more foundation work |
|
@johnmccutchan Since you're not going to be working on this for a few days I'm going to close the PR for now so that it isn't in our review queue. Please don't hesitate to reopen it when you're ready for review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.