[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScaffoldMessenger #64101

Merged
merged 11 commits into from
Sep 3, 2020
Merged

ScaffoldMessenger #64101

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d608e4a
ScaffoldMessenger
Piinks Aug 26, 2020
8f7593c
Remove unintended changes
Piinks Aug 26, 2020
6e784ab
Fix sample
Piinks Aug 26, 2020
20d8afd
++
Piinks Aug 26, 2020
d9f57e3
Apply suggestions from code review
Piinks Aug 26, 2020
063e159
Update docs
Piinks Aug 27, 2020
c4632bd
Review feedback
Piinks Aug 28, 2020
843e287
Sample app
Piinks Aug 28, 2020
2042863
Merge branch 'master' of github.com:flutter/flutter into scaffoldMess…
Piinks Aug 31, 2020
e3cd0d7
Fix sample code
Piinks Aug 31, 2020
72469cd
Review feedback
Piinks Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@Piinks
Piinks committed Aug 26, 2020
commit d9f57e3f5500a3354782de9e2051c1fecc228014
12 changes: 0 additions & 12 deletions packages/flutter/lib/src/material/scaffold.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,10 +2066,6 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin {
/// ```
/// {@end-tool}
// TODO(Piinks): Deprecate after customers are migrated
// @Deprecated(
// 'Use ScaffoldMessenger.showSnackBar instead. '
// 'This feature was deprecated after TBD'
// )
ScaffoldFeatureController<SnackBar, SnackBarClosedReason> showSnackBar(SnackBar snackbar) {
assert(() {
if(_scaffoldMessenger == null) {
Expand Down Expand Up @@ -2101,10 +2097,6 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin {
/// The removed snack bar does not run its normal exit animation. If there are
/// any queued snack bars, they begin their entrance animation immediately.
// TODO(Piinks): Deprecate after customers are migrated
// @Deprecated(
// 'Use ScaffoldMessenger.removeCurrentSnackBar instead. '
// 'This feature was deprecated after TBD'
// )
void removeCurrentSnackBar({ SnackBarClosedReason reason = SnackBarClosedReason.remove }) {
assert(() {
if(_scaffoldMessenger == null) {
Expand Down Expand Up @@ -2135,10 +2127,6 @@ class ScaffoldState extends State<Scaffold> with TickerProviderStateMixin {
///
/// The closed completer is called after the animation is complete.
// TODO(Piinks): Deprecate after customers are migrated.
// @Deprecated(
// 'Use ScaffoldMessenger.hideCurrentSnackBar instead. '
// 'This feature was deprecated after TBD'
// )
void hideCurrentSnackBar({ SnackBarClosedReason reason = SnackBarClosedReason.hide }) {
assert(() {
if(_scaffoldMessenger == null) {
Piinks marked this conversation as resolved.
Show resolved Hide resolved
Expand Down