[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pre/post submit hostonly tests. #65985

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Enable pre/post submit hostonly tests. #65985

merged 1 commit into from
Sep 17, 2020

Conversation

godofredoc
Copy link
Contributor

Description

Hostonly tests were split and now they are being enabled in the
dashboard and presubmit.

Related Issues

Bug:
#65223
#63242

Tests

N/A

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@godofredoc
Enable pre/post submit hostonly tests.
09ba0d1 
Hostonly tests were split and now they are being enabled in the
dashboard and presubmit.

Bug:
  flutter#65223
  flutter#63242
@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Sep 17, 2020
@skia-gold
Copy link

Gold has detected about 3 untriaged digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/65985

keyonghan
keyonghan approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor
@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick enabling/splitting these tests.

christopherfujino
christopherfujino approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member
@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 8cb09cf into flutter:master Sep 17, 2020
goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
@godofredoc @goderbauer
Enable pre/post submit hostonly tests. (flutter#65985)
96a3d37
@godofredoc godofredoc added this to To do in Migration to LUCI via automation Oct 16, 2020
@godofredoc godofredoc moved this from To do to Done in Migration to LUCI Jan 9, 2021
@godofredoc godofredoc deleted the add_devicelab_tests branch October 18, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
Migration to LUCI
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@godofredoc @skia-gold @christopherfujino @keyonghan @googlebot @fluttergithubbot