Add the ability to inject a bootstrap script #66897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this could be tested in packages/flutter_tools/test/integration.shard/command_output_test.dart
Create a test that write a bootstrap file that echos something, run flutter and then asset that the echo is in the stdout. For example
testWithoutContext('will load bootstrap script before starting', () async {
final String flutterBin = fileSystem.path.join(getFlutterRoot(), 'bin', 'flutter');
final File bootstrap = fileSystem.file(
fileSystem.path.join(
getFlutterRoot(),
'bin',
'internal',
platform.isWindows ? 'boostrap.bat' : 'bootstap',
));
// Something different per platform., make it executable.
bootstrap.writeAsStringSync('contents');
final ProcessResult result = await processManager.run(<String>[
flutterBin,
...getLocalEngineArguments(),
]);
// Development tools.
expect(result.stdout, contains(''));
});
|
(Also make sure to delete the bootstrap after the test is done in a finally block |
jonahwilliams
approved these changes
Sep 29, 2020
|
👍 thanks for the contribution - great to see this land! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to inject a custom bootstrap script on Mac, Linux (via
bin/internal/bootstrap.sh), and Windows (viabin/internal/bootstrap.bat).The primary purpose for this change is to enable wider IDE support for the flutter snap on Linux by having the snap inject a bootstrap script that sets up the environment required to ensure its build dependancies can be found (See issues linked below).
Related Issues
Resolves: #66414
Resolves: flutter/flutter-intellij#4746
Resolves: canonical/flutter-snap#8
Tests
Added 'will load bootstrap script before starting' test to
command_output_test.dart.Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.