fail when chromedriver installation fails #67564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Oct 7, 2020
|
Would granting more memory help? |
I don't. BTW this PR should also fix a race condition. It seems previously we kicked off the chromedriver installation then assumed that it would finish in 5 seconds. Nothing guarantees that. |
angjieli
approved these changes
Oct 7, 2020
6691167
to
a04557d
Compare
To follow-up. The chromedriver started failing due to Chrome version change. Fixed in flutter/web_installers#21. Why the Firefox driver test is failing, I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
web_driver_installer.dartandsleep 5Related Issues
#67560