Support drag-to-dismiss in persistent bottom sheets #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void _handleDragEnd(Offset velocity, BuildContext context) { | ||
| if (_dismissUnderway) | ||
| return; | ||
| if (velocity.dy > _kMinFlingVelocity) |
|
LGTM |
HansMuller
pushed a commit
that referenced
this pull request
Nov 9, 2015
Support drag-to-dismiss in persistent bottom sheets Flinging a persistent bottom sheet downwards dismisses it, per the Material spec. The showBottomSheet() function now returns a Future, like showModalBottomSheet() does, so that you can discover when it's been dismissed - with navigator.pop() - and with what value. Factored the drag gesture handling code into _BottomSheetDragController This CL was flutter/engine#1997
Closed
This was referenced Oct 16, 2020
This was referenced Dec 11, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flinging a persistent bottom sheet downwards dismisses it, per the Material spec.
The showBottomSheet() function now returns a Future, like showModalBottomSheet() does, so that you can discover when it's been dismissed - with navigator.pop() - and with what value.
Factored the drag gesture handling code into _BottomSheetDragController
This CL was flutter/engine#1997