Deprecate iOS13 style ActivityIndicator #62741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1 similar comment
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 16 untriaged digest(s) on patchset 1. |
|
Gold has detected about 16 untriaged digest(s) on patchset 2. |
|
Gold has detected about 32 untriaged digest(s) on patchset 2. |
|
Fine. |
justinmc
reviewed
Aug 3, 2020
| @@ -21,6 +21,10 @@ const Color _kActiveTickColor = CupertinoDynamicColor.withBrightness( | |||
| /// Define the iOS version style of [CupertinoActivityIndicator]. | |||
| enum CupertinoActivityIndicatorIOSVersionStyle { | |||
| /// The style that is used in iOS13 and earlier (12 points). | |||
| @Deprecated( | |||
| 'Use iOS14 instead or simply leave this field to default. ' | |||
| 'This feature was deprecated after v1.21.0.' | |||
There was a problem hiding this comment.
Suggested change
| 'This feature was deprecated after v1.21.0.' | |
| 'This feature was deprecated after v1.21.0-1.0.pre.' |
Is this suggestion exactly what you tried before, and it still didn't work? What if you try 1.20.0-7.1.pre?
|
Gold has detected about 3 untriaged digest(s) on patchset 3. |
|
Those skia gold changes are expected, since this PR changes the default appearance from iOS13 to iOS14 style. I've accepted the changes to the gold images. Also, there seems to be a test failure. @ctrysbita Do you see this failure if you run the test locally? Test failure output |
|
@justinmc I'm working on fixing it. |
|
I think I've seen the current failure in another PR before (something about "forEach called on null"). Can you update the branch with master? |
|
@justinmc I've rebased my branch onto latest master. |
justinmc
reviewed
Aug 11, 2020
There was a problem hiding this comment.
@ctrysbita Would you mind bringing back the deleted test that I mentioned in the comment below? Then I think this is ready to merge. Thanks for getting the tests to go green.
| @@ -77,60 +77,6 @@ void main() { | |||
| ); | |||
| }); | |||
|
|
|||
| testWidgets('Activity indicator with iOS14 style', | |||
There was a problem hiding this comment.
I think it's still valuable to keep this test around. Just leave off iOSVersionStyle so it defaults to iOS14?
There was a problem hiding this comment.
The original tests are now default to iOS14 so we nolonger need these iOS14 tests.
But should we add some tests for iOS13 style?
There was a problem hiding this comment.
Oh I see. No I think it's fine since iOS13 will be removed in the future.
Alright this looks good and should be merged when our build is green. Thanks for following up with this work!
|
This pull request is not suitable for automatic merging in its current state.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate iOS13 style
CupertinoActivityIndicator.Related Issues
#62521
Tests
No changes to tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.