-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate iOS13 style ActivityIndicator #62741
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1 similar comment
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Gold has detected about 16 untriaged digest(s) on patchset 1. |
Gold has detected about 16 untriaged digest(s) on patchset 2. |
Gold has detected about 32 untriaged digest(s) on patchset 2. |
Fine. |
@@ -21,6 +21,10 @@ const Color _kActiveTickColor = CupertinoDynamicColor.withBrightness( | |||
/// Define the iOS version style of [CupertinoActivityIndicator]. | |||
enum CupertinoActivityIndicatorIOSVersionStyle { | |||
/// The style that is used in iOS13 and earlier (12 points). | |||
@Deprecated( | |||
'Use iOS14 instead or simply leave this field to default. ' | |||
'This feature was deprecated after v1.21.0.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'This feature was deprecated after v1.21.0.' | |
'This feature was deprecated after v1.21.0-1.0.pre.' |
Is this suggestion exactly what you tried before, and it still didn't work? What if you try 1.20.0-7.1.pre?
Gold has detected about 3 untriaged digest(s) on patchset 3. |
Those skia gold changes are expected, since this PR changes the default appearance from iOS13 to iOS14 style. I've accepted the changes to the gold images. Also, there seems to be a test failure. @ctrysbita Do you see this failure if you run the test locally? Test failure output
|
@justinmc I'm working on fixing it. |
I think I've seen the current failure in another PR before (something about "forEach called on null"). Can you update the branch with master? |
@justinmc I've rebased my branch onto latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrysbita Would you mind bringing back the deleted test that I mentioned in the comment below? Then I think this is ready to merge. Thanks for getting the tests to go green.
@@ -77,60 +77,6 @@ void main() { | |||
); | |||
}); | |||
|
|||
testWidgets('Activity indicator with iOS14 style', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still valuable to keep this test around. Just leave off iOSVersionStyle
so it defaults to iOS14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original tests are now default to iOS14 so we nolonger need these iOS14 tests.
But should we add some tests for iOS13 style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. No I think it's fine since iOS13 will be removed in the future.
Alright this looks good and should be merged when our build is green. Thanks for following up with this work!
This pull request is not suitable for automatic merging in its current state.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Deprecate iOS13 style
CupertinoActivityIndicator
.Related Issues
#62521
Tests
No changes to tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.