Add ephemeral iOS directory to put future generated files #76830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Feb 25, 2021
| @@ -18,6 +18,7 @@ Flutter/App.framework | |||
| Flutter/Flutter.framework | |||
| Flutter/Flutter.podspec | |||
| Flutter/Generated.xcconfig | |||
| Flutter/ephemeral/ | |||
There was a problem hiding this comment.
\cc @RedBrogdon Sorry here's another directory to add to all the iOS sample .gitignores. But new ones should be rare in the future with this PR.
Oh that reminds me, better do the same for the examples/integration_tests in this repo... |
jmagman
commented
Feb 25, 2021
| @@ -92,6 +92,7 @@ unlinked_spec.ds | |||
| **/ios/Flutter/Flutter.framework | |||
| **/ios/Flutter/Flutter.podspec | |||
| **/ios/Flutter/Generated.xcconfig | |||
| **/ios/Flutter/ephemeral | |||
There was a problem hiding this comment.
The other non-template .gitignores aren't necessary on top of this one, but let's be consistent.
stuartmorgan
approved these changes
Feb 25, 2021
Naming is hard. "modules" also references several concepts. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future prevention of #39491 on iOS. There's nothing currently generated in this ephemeral directory, but I'm about to put out a PR that will generate a few files to this location.
ephemeralDirectory->ephemeralModuleDirectoryFlutter/ephemeraldirectory.ephemeralDirectoryonflutter cleanThis doesn't actually move any existing generated files to this location--that can be done in individual follow-up PRs as needed.