-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ephemeral iOS directory to put future generated files #76830
Conversation
@@ -18,6 +18,7 @@ Flutter/App.framework | |||
Flutter/Flutter.framework | |||
Flutter/Flutter.podspec | |||
Flutter/Generated.xcconfig | |||
Flutter/ephemeral/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\cc @RedBrogdon Sorry here's another directory to add to all the iOS sample .gitignore
s. But new ones should be rare in the future with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh that reminds me, better do the same for the examples/integration_tests in this repo... |
@@ -92,6 +92,7 @@ unlinked_spec.ds | |||
**/ios/Flutter/Flutter.framework | |||
**/ios/Flutter/Flutter.podspec | |||
**/ios/Flutter/Generated.xcconfig | |||
**/ios/Flutter/ephemeral |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other non-template .gitignore
s aren't necessary on top of this one, but let's be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
Apologies for the naming collision; I didn't realize there was already something called "the ephemeral directory" when I made this concept for desktop, and by the time I realized it would have been a giant pain to change.
Naming is hard. "modules" also references several concepts. 😄 |
Future prevention of #39491 on iOS. There's nothing currently generated in this ephemeral directory, but I'm about to put out a PR that will generate a few files to this location.
ephemeralDirectory
->ephemeralModuleDirectory
Flutter/ephemeral
directory.ephemeralDirectory
onflutter clean
This doesn't actually move any existing generated files to this location--that can be done in individual follow-up PRs as needed.