[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flutter-cirrus gke cluster for framework tasks. #77982

Merged
merged 16 commits into from
Mar 19, 2021
Merged

Use flutter-cirrus gke cluster for framework tasks. #77982

merged 16 commits into from
Mar 19, 2021

Conversation

godofredoc
Copy link
Contributor
@godofredoc godofredoc commented Mar 12, 2021 •
edited

Start using flutter-cirrus gke cluster for linux framework tasks. This is in preparation to enable alerts, metrics and monitoring for the different flutter repositories.

Bug: #77624

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 12, 2021
@goderbauer goderbauer added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Mar 12, 2021
@christopherfujino
Copy link
Member

Looking at the cirrus docker pre-build failure, I think it's a flake (I'm able to curl the file locally). Triggered a re-run https://cirrus-ci.com/task/5513951426379776

@christopherfujino
Copy link
Member
christopherfujino commented Mar 16, 2021 •
edited

Hmm, so the re-run got further, but I suspect this failure will need either a dockerfile change or a config change.

debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype

This issue has several possible fixes, setting ENV TERM linux in the dockerfile seems promising.

@godofredoc godofredoc changed the title Test using VMs Use flutter-cirrus gke cluster for framework tasks. Mar 17, 2021
@godofredoc
Copy link
Contributor Author

Hmm, so the re-run got further, but I suspect this failure will need either a dockerfile change or a config change.

debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype

This issue has several possible fixes, setting ENV TERM linux in the dockerfile seems promising.

Thanks I made the updates and now everything is working as expected.

@godofredoc
Copy link
Contributor Author

This PR is now ready for review.

@godofredoc godofredoc force-pushed the check_vms_project branch 2 times, most recently from e4dfa69 to c28bc87 Compare March 18, 2021 06:46
christopherfujino
christopherfujino reviewed Mar 18, 2021
View reviewed changes
.cirrus.yml
dockerfile: "dev/ci/docker_linux/Dockerfile"
builder_image_name: docker-builder # gce vm image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is the same VM that we use to build docker images for the engine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is the same. The idea is to make all the repos use Cirrus in a similar way and encapsulate them to a single service account and gcp project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

christopherfujino
christopherfujino approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member
@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit eb1868b into flutter:master Mar 19, 2021
@fkorotkov
Copy link
Contributor

Hey @godofredoc,

FYI there are some issues on your GKE cluster. Pod status for this task constantly reports that it's waiting with this message:

failed to reserve container name "main_cirrus-ci-task-4941454465302528_default_ca22180a-a7a2-4432-98d6-d8a32732a9a9_0": name "main_cirrus-ci-task-4941454465302528_default_ca22180a-a7a2-4432-98d6-d8a32732a9a9_0" is reserved for "da923bfa5ed0775ec8a3a0fd1fb32702271b3a18bac2d51c02daad54f0a37adb"

Seems this issue is related to containerd/containerd#4604. Just wanted to let you know.

@godofredoc godofredoc deleted the check_vms_project branch October 18, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@godofredoc @christopherfujino @fluttergithubbot @fkorotkov @goderbauer